From c032f5405cd0d6d79c5021d39edef20d19a2633a Mon Sep 17 00:00:00 2001 From: Serhii Filonenko Date: Fri, 15 Nov 2024 13:05:58 +0200 Subject: [PATCH] HCK-8277: remove column definitions from script for iceberg table with external catalog --- forward_engineering/ddlProvider.js | 5 ++++- package-lock.json | 6 +++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/forward_engineering/ddlProvider.js b/forward_engineering/ddlProvider.js index 6ea7cc94..292d5e35 100644 --- a/forward_engineering/ddlProvider.js +++ b/forward_engineering/ddlProvider.js @@ -347,6 +347,9 @@ module.exports = (baseProvider, options, app) => { }); if (tableData.dynamic || tableData.iceberg) { + const isExternalCatalog = tableData.iceberg && tableData.tableExtraProps.catalogMgmt === 'external'; + const tableColumnDefinitions = isExternalCatalog ? '' : columnDefinitions; + const tableExtraOptions = getTableExtraProps({ tableData, tagsStatement, @@ -354,7 +357,7 @@ module.exports = (baseProvider, options, app) => { comment, dataRetentionTime, copyGrants, - columnDefinitions, + columnDefinitions: tableColumnDefinitions, }); return assignTemplates(templates.createDynamicTable, { diff --git a/package-lock.json b/package-lock.json index 16ac33be..f1377e12 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "Snowflake", - "version": "0.2.8", + "version": "0.2.14", "lockfileVersion": 3, "requires": true, "packages": { "": { "name": "Snowflake", - "version": "0.2.8", + "version": "0.2.14", "dependencies": { "async": "3.2.6", "axios": "1.7.7", @@ -33,7 +33,7 @@ "simple-git-hooks": "2.11.1" }, "engines": { - "hackolade": "6.1.2", + "hackolade": "7.7.10", "hackoladePlugin": "1.2.0" } },