Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Create a minimum aspect ratio for hero images #205

Open
Pinpickle opened this issue Jan 18, 2018 · 1 comment
Open

Proposal: Create a minimum aspect ratio for hero images #205

Pinpickle opened this issue Jan 18, 2018 · 1 comment

Comments

@Pinpickle
Copy link
Contributor

Currently, hero images are a fixed width, and their "foreground" will expand to fit the space without clipping them.

image

Some hero foregrounds (see Git) have images that are expected to fill the full height of the image. Once the hero image gets thin enough, that would in fact be violated.

image

As this extra height isn't really adding anything, I'm proposing we have a minimum aspect ratio for hero images (e.g. 16:9), and if maintaining constant height would make it thinner than that ratio, the height is decreased (this can be done with CSS).

@Pinpickle Pinpickle changed the title Create a minimum aspect ratio for hero images Proposal: Create a minimum aspect ratio for hero images Jan 18, 2018
@Pinpickle
Copy link
Contributor Author

Pinpickle commented Jan 18, 2018

I should have been clearer about the downsides of this approach, so I'm not sure if we should actually do this. The biggest downside is that we can't have thin and tall heroes (even square ones). Which is a nice property, especially for the home page where we put a hero next to something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant