Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly escape strings that are encoded to JavaScript #117

Open
moosichu opened this issue Nov 6, 2017 · 0 comments
Open

Properly escape strings that are encoded to JavaScript #117

moosichu opened this issue Nov 6, 2017 · 0 comments
Labels
backend bug priority medium

Comments

@moosichu
Copy link
Contributor

moosichu commented Nov 6, 2017 •
edited
Loading

Screenshot of bug:

screenshot from 2017-11-06 22-14-32

Explanation of bug:

Currently, when encoding strings to be passed to JavaScript, we don't properly encode them. It is incredibly important that this gets fixed!

Upgrading to Swift 4 might help with this, as they provide encoders and decoders.

The code for this has yet to be merged, and is in the branch in pull requst #113 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend bug priority medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Pinpickle @moosichu