Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code style? #42

Open
jas14 opened this issue Dec 24, 2015 · 7 comments
Open

code style? #42

jas14 opened this issue Dec 24, 2015 · 7 comments

Comments

@jas14
Copy link
Contributor

jas14 commented Dec 24, 2015

can we get a code style guide? obviously since we're using python it would be easiest to use pep8 (my vote), which can be verified with pyflake/flake8 and autopep8.

@jas14 jas14 added the question label Dec 24, 2015
@hpincket
Copy link
Collaborator

I pyflake8 by default.

On Wednesday, December 23, 2015, Joe Stein [email protected] wrote:

can we get a code style guide? obviously since we're using python it would
be easiest to use pep8 (my vote), which can be verified with pyflake/flake8
and autopep8.


Reply to this email directly or view it on GitHub
#42.

@joengelm
Copy link
Member

yeah, pep8 seems to be the popular/best choice

@joengelm
Copy link
Member

It would be great for us to start enforcing this. Can someone take a look?

@hpincket
Copy link
Collaborator

Since we're open source, we could setup Travis CI to auto-lint pull requests (see link).
We could also manually flake8 the whole thing. I'm happy to go through and clean up existing code if we decide on a linter (since this requires little effort and I don't want to think hard).

http://eldarion.com/blog/2014/06/03/how-we-work-continuous-integration/

@jas14
Copy link
Contributor Author

jas14 commented Aug 28, 2016

I vote Travis, sounds fresh. @hpincket do you want to take this? if not, assign to me 😄

@hpincket
Copy link
Collaborator

Of course I want it :D

@hpincket
Copy link
Collaborator

hpincket commented Sep 1, 2016

Travis is looking at this repo in #62

.travis.yml tells travis to run flake8
.flake8 holds project specific settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants