Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Cron Expression Editor does not work properly for "daily tab" Week Day (MON-FRI) radio option #35

Open
MartinMilata opened this issue Apr 26, 2024 · 3 comments

Comments

@MartinMilata
Copy link

1.Go to daily tab
2.Click Week Day (MON-FRI) radio option
3.Set for example at time: 1H, 5min, 3sec - expression will be changed to Expression: 3 5 1 ? * MON-FRI *
4.This expression I saved to db - 3 5 1 ? * MON-FRI *
5.ngOnInit I get this expression data from db, and set reactive forms like this:

this.form = this.fb.group({
cronExpression: [this.item.cronExpression]
});

  1. There are not set radio option Week Day (MON-FRI) , there are set first radio option..All other inputs are set correctly..
  2. This problem IS NOT in monthly or yearly tab, where we also have two radio options.. In those tabs monthly, yearly - there are those seconds radion options set correctly... When I click to update button - I mean <mat-button-toggle i18n (click)="form.patchValue({expression: form.value.expression})">Update the Week Day (MON-FRI) radio option is set correctly...

My code:
ts:
cronOptions: CronOptions = {
defaultTime: "00:00:00",

hideMinutesTab: false,
hideHourlyTab: false,
hideDailyTab: false,
hideWeeklyTab: false,
hideMonthlyTab: false,
hideYearlyTab: false,
hideAdvancedTab: true,
hideSpecificWeekDayTab: false,
hideSpecificMonthWeekTab: false,

use24HourTime: true,
hideSeconds: false,

cronFlavor: "quartz" //standard or quartz

};

html
<cron-editor formControlName="cronExpression" [options]="cronOptions">

haavardj pushed a commit that referenced this issue Oct 25, 2024
This commit adds parsing of weekday (MON-FRI) and weekends (SAT-SUN) day ranges.

closes issue #35
@haavardj
Copy link
Owner

haavardj commented Oct 25, 2024

Should be (partially) fixed in release 0.10.1

@MartinMilata
Copy link
Author

I updated to 10.1. but the problem is still there. It is not fixed...

@haavardj
Copy link
Owner

I have replicated the error. Let me see if it is fixable.

@haavardj haavardj reopened this Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants