-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing commits in 1.24.4 release #147
Comments
I'm seeing the same issues, for example in https://github.com/h5p/h5p-editor-php-library/blob/1.24.2/h5peditor.class.php#L376 |
That is 115 very diverse commits so there is no way it's intentional. |
I checked the 2 commits above and they are in 1.25: https://github.com/h5p/h5p-editor-php-library/commits/1.25 |
In trying to track down a bug, I noticed that there are ~2 years worth of commits that were in the 1.24.2 release tag, but are no longer in the most recent 1.24.4 release. Was that intentional and is there a reason for it?
Specifically, I was trying to figure out why .JPG uploads are being rejected while .jpg (lowercase) files work. While looking into that, I realized the issue had already been fixed in commit bd871a3 back in November 2019.
However, it appears that that commit, and in fact all commits from Nov. 2019 to June 2021 were (inadvertently?) dropped from the 1.24.4 tagged release.
You can see everything missing by comparing the 1.24.2 tag to 1.24.4: 1.24.4...1.24.2
The text was updated successfully, but these errors were encountered: