-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sequentially evaluating and replacing drivers #19
Comments
Something I just had in mind (for my specific use-case) is a function that takes a generic Though that seems weirdly add-hoc and ugly, and it is perhaps cleaner to just have my A/B on the stack sequentially, while the rotations are multiplied in |
Swapping of drivers at runtime is not something I've given any thought. When changing cameras in my apps, I'm just replacing the entire rig, and so far that has worked fine. That might not be sufficient for your use case, but in practical terms I won't have the resources to look into this myself 👀 😅 |
Hey! We're using
dolly
and wanting to swap out camera drivers at runtime (specificallyRotation
andYawPitch
). There are no helpers to expose this in the public API, but since thedrivers
Vec
is (perhaps unintentionally)pub
we can patch those in. Is that an intended use-case?As an alternative approach we also looked into having both drivers on the stack so that we could set one of the two to
IDENTITY
, but as it turns outdolly
doesn't really stack the drivers sequentially, instead thePosition
/Rotation
/YawPitch
(and maybe all the other) drivers replace a translation or rotation onupdate()
, meaning only the lastrotation
orposition
sticks. This is also visible in theREADME
example, where a camera has aRotation
(that is updated) but useless because the subsequentLookAt
overwrites the rotation.The text was updated successfully, but these errors were encountered: