Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRANSFORM/REST] Handle mismatched column names in the requests #62

Open
osery opened this issue May 17, 2019 · 0 comments
Open

[TRANSFORM/REST] Handle mismatched column names in the requests #62

osery opened this issue May 17, 2019 · 0 comments
Assignees

Comments

@osery
Copy link
Contributor

osery commented May 17, 2019

Currently, if the input request contains columns that do not match the columns expected by the pipeline, these are silently ignored and the input has NaNs instead. This leads to rather cryptic behavior in real life cases where the input request contains a typo or a lower/upper case differences in the column names.

It would be safer to return error on these requests to make the discrepancy obvious and let the caller decide if an empty value should be used instead or not (= fail fast).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant