-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export an Error to signify missing nodes #73
Comments
Could you send a PR to implement this? Thanks! |
I'll try to get something out within the next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
goraph uses
errors.New()
to create errors to signal missing graph nodes in numerous places. e.g.return fmt.Errorf("%s does not exist in the graph.", id1)
It would be better to create specific error type instead. This would reduce code duplication and would allow callers to distinguish missing nodes from other things that may have go wrong when using the library.
The text was updated successfully, but these errors were encountered: