Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ActionRequirement): improve accessibility #851

Merged
merged 10 commits into from
Nov 27, 2024
Merged

feat(ActionRequirement): improve accessibility #851

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b37f671
feat(ActionRequirement): improve accessibility
mavericardo Nov 19, 2024
434fcaf
refactor: removes unnecessary tabIndex
mavericardo Nov 19, 2024
020859a
refactor: adjust code formatting
mavericardo Nov 19, 2024
55b225d
refactor: adjust code formatting
mavericardo Nov 19, 2024
c236e46
Update packages/yoga/src/ActionRequirement/web/ActionRequirement.jsx
mavericardo Nov 19, 2024
31e9647
refactor: adjust code formatting
mavericardo Nov 19, 2024
9112dee
test: update snapshot
mavericardo Nov 19, 2024
5c46039
refactor: adjust lint
mavericardo Nov 25, 2024
d33cfd9
refactor: removes unnecessary aria-label
mavericardo Nov 25, 2024
d1ad094
test: update snapshots
mavericardo Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions packages/yoga/src/ActionRequirement/web/ActionRequirement.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,15 +73,18 @@ function ActionRequirement(props) {
defineCompoundComponents();
return (
<StyledActionRequirement {...props}>
{illustration && <BoxIllustration>{illustration}</BoxIllustration>}

{illustration && (
<BoxIllustration aria-hidden="true">{illustration}</BoxIllustration>
leonardo-gympass marked this conversation as resolved.
Show resolved Hide resolved
)}
<Content>
{titleAsTextDisplay ? (
<Text.Display2>{title}</Text.Display2>
<Text.Display2 as="h1" aria-label={title}>
{title}
</Text.Display2>
) : (
<Title>{title}</Title>
<Title aria-label={title}>{title}</Title>
)}
<Text.Body1 mt="small" color="deep">
<Text.Body1 mt="small" color="deep" aria-label={description}>
leonardo-gympass marked this conversation as resolved.
Show resolved Hide resolved
{description}
</Text.Body1>
{list && <Box mt="large">{list}</Box>}
Expand Down
2 changes: 1 addition & 1 deletion packages/yoga/src/ActionRequirement/web/ActionRequirementStyles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Box from '../../Box';
import Button from '../../Button';

export const Title = styled(Text.H4).attrs({
as: 'p',
as: 'h1',
bold: true,
})`
${({
Expand Down
18 changes: 12 additions & 6 deletions packages/yoga/src/ActionRequirement/web/__snapshots__/ActionRequirement.test.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,12 +112,14 @@ exports[`<ActionRequirement /> should default match snapshot 1`] = `
<div
class="c1"
>
<p
<h1
aria-label="title"
class="c2"
>
title
</p>
</h1>
<p
aria-label="description"
class="c3"
color="deep"
>
Expand Down Expand Up @@ -271,12 +273,14 @@ exports[`<ActionRequirement /> should match snapshot with list 1`] = `
<div
class="c1"
>
<p
<h1
aria-label="title"
class="c2"
>
title
</p>
</h1>
<p
aria-label="description"
class="c3"
color="deep"
>
Expand Down Expand Up @@ -418,12 +422,14 @@ exports[`<ActionRequirement /> should match snapshot with text display 1`] = `
<div
class="c1"
>
<p
<h1
aria-label="title"
class="c2"
>
title
</p>
</h1>
<p
aria-label="description"
class="c3"
color="deep"
>
Expand Down
Loading