Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ssl.PROTOCOL_TLS #71

Closed
wants to merge 1 commit into from
Closed

Replace ssl.PROTOCOL_TLS #71

wants to merge 1 commit into from

Conversation

cdce8p
Copy link

@cdce8p cdce8p commented Sep 2, 2023

ssl.PROTOCOL_TLS is deprecated in favor of ssl.PROTOCOL_TLS_CLIENT and ssl.PROTOCOL_TLS_SERVER.
https://docs.python.org/3.11/library/ssl.html#ssl.PROTOCOL_TLS

@gwww
Copy link
Owner

gwww commented Sep 4, 2023

I’m travelling for the next two weeks and cannot test. Has this been tested? Maybe @bdraco can take a look?

@gwww
Copy link
Owner

gwww commented Sep 17, 2023

I just tried the change and the following error occurred:

[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: self signed certificate (_ssl.c:1002)

Unfortunately, I'm unsure of what other options may need to be set to make this work. I'm doing some reading to see if I can find the answer, but if you know of something I can try that would help. Thanks!

@bdraco
Copy link
Contributor

bdraco commented Sep 17, 2023

Tested that and got the same.

The behavior is different in that is explicitly enables verification and there is no valid chain to verify with these devices

@bdraco
Copy link
Contributor

bdraco commented Sep 17, 2023

Sorry I missed your original message. I've been traveling a bit and with the fires in Lahaina everything has been a bit chaotic

@bdraco
Copy link
Contributor

bdraco commented Sep 17, 2023

I'll prepare a new PR shortly

@cdce8p
Copy link
Author

cdce8p commented Sep 17, 2023

Superseded by #72

@cdce8p cdce8p closed this Sep 17, 2023
@cdce8p cdce8p deleted the fix-ssl branch September 17, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants