Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the holiday file configured in timewarrior.cfg #8

Open
Blackjacx opened this issue Jan 2, 2024 · 3 comments
Open

Using the holiday file configured in timewarrior.cfg #8

Blackjacx opened this issue Jan 2, 2024 · 3 comments

Comments

@Blackjacx
Copy link

It looks like you only use the en-US holiday file to exclude public holidays. Is that possible? In Germany we have Jan 1st off and I explicitly have to enter it in balance.conf. This could be a hint that the extension does not take into account when a user specifies import /opt/homebrew/share/doc/timew/holidays/holidays.de-DE in timewarrior.cfg.

@guludo
Copy link
Owner

guludo commented Jan 3, 2024

Actually, timewarrior-balance does not use any holiday file at the moment. We could think of a way of using it. Patches are welcome :-)

@Blackjacx
Copy link
Author

Ah so that means each holiday in any country should be entered in balance.conf when I want to exclude it from calculations.

@guludo
Copy link
Owner

guludo commented Feb 6, 2024

Yes. That's the current way to do it. I think using an external holiday file has some value, but we need to think of how that should be implemented: given a holiday, we need to make timewarrior-balance know what tags that would be applied to and how much time to consider. For the latter, maybe a sane default would be to match the hours of whatever config entry is on that day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants