Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add global tracking and warning on duplicate ties definitions #43

Open
gullerya opened this issue Mar 1, 2020 · 0 comments
Open

add global tracking and warning on duplicate ties definitions #43

gullerya opened this issue Mar 1, 2020 · 0 comments
Assignees
Milestone

Comments

@gullerya
Copy link
Owner

gullerya commented Mar 1, 2020

The data-tier is built to be able to run multiple times within the same page.
All of the instances will collect the views, and all of them will process and track them, each for it's own.

BUT, the DOM is global, not encapsulated. Therefore, if several data-tier instances will define the same tie key, they'll struggle over the same views and will update them together - mess.

  1. Should at least have some warning on the duplication of tie keys globally.
  2. Should probably enforce global uniqueness of the tie keys
@gullerya gullerya added this to the 2.9 milestone Mar 1, 2020
@gullerya gullerya self-assigned this Mar 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant