Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect /httpcat arguments don't cause error #614

Open
guidojw opened this issue Jan 12, 2024 · 1 comment · May be fixed by #615
Open

Incorrect /httpcat arguments don't cause error #614

guidojw opened this issue Jan 12, 2024 · 1 comment · May be fixed by #615
Labels
bug Something isn't working

Comments

@guidojw
Copy link
Owner

guidojw commented Jan 12, 2024

Someone ran /httpcat 100000000 and it incorrectly outputted a formatted URL where it should have thrown an error instead. This might be a bigger problem in the dispatcher with argument parsing, not sure yet.
@guidojw guidojw added the bug Something isn't working label Jan 12, 2024
@guidojw
Copy link
Owner Author

guidojw commented Jan 12, 2024 •
edited
Loading

Culprit: only string values are going through the validation process, look into improving this.
https://github.com/guidojw/arora-discord/blob/staging/src/client/dispatcher.ts#L138-L141

@guidojw guidojw linked a pull request Jan 14, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: arg type handling guidojw/arora-discord
1 participant
@guidojw