From f5b239777a17970fe58ff6735c8a13824748b362 Mon Sep 17 00:00:00 2001
From: Guido de Jong <35309288+guidojw@users.noreply.github.com>
Date: Sun, 4 Jun 2023 20:50:29 +0200
Subject: [PATCH] refactor(GuildTicketManager): set permissionOverwrites in
 channel create call (#570)

---
 src/managers/guild-ticket.ts | 19 +++++++------------
 1 file changed, 7 insertions(+), 12 deletions(-)

diff --git a/src/managers/guild-ticket.ts b/src/managers/guild-ticket.ts
index 22e2abdf..f85979aa 100644
--- a/src/managers/guild-ticket.ts
+++ b/src/managers/guild-ticket.ts
@@ -2,6 +2,7 @@ import {
   type ButtonInteraction,
   EmbedBuilder,
   type GuildMemberResolvable,
+  PermissionFlagsBits,
   TextChannel,
   type TextChannelResolvable
 } from 'discord.js'
@@ -57,23 +58,17 @@ export default class GuildTicketManager extends DataManager<number, Ticket, Tick
     }
 
     const channelName = `${ticketType.name}-${author.user.tag}`
+    const permissionOverwrites = this.context.ticketsCategory?.permissionOverwrites.cache.toJSON() ?? []
     let channel
     try {
       channel = await this.context.guild.channels.create({
         name: channelName,
-        parent: this.context.ticketsCategory ?? undefined
+        parent: this.context.ticketsCategory ?? undefined,
+        permissionOverwrites: [...permissionOverwrites, {
+          id: author.id,
+          allow: [PermissionFlagsBits.ViewChannel]
+        }]
       })
-
-      // In random occassions on the Twin-Rail server, the permission overwrites
-      // creation shows up in the audit log but not actually in the channel's
-      // permissions tab. Force fetch the channel from the API first to make
-      // sure it was created before creating the permission overwrites.
-      channel = await this.context.guild.channels.fetch(channel.id, { force: true })
-      if (channel === null || !channel.isTextBased() || channel.isThread()) {
-        throw new Error('Could not find channel.')
-      }
-
-      await channel.permissionOverwrites.create(author, { ViewChannel: true })
     } catch (err) {
       await channel?.delete()
       throw err