Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump SonarAnalyzer.CSharp from 9.16.0.82469 to 9.17.0.82934 #291

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 22, 2024

Bumps SonarAnalyzer.CSharp from 9.16.0.82469 to 9.17.0.82934.

Release notes

Sourced from SonarAnalyzer.CSharp's releases.

9.17

Hi everyone!

We are shipping some more improvements to our Symbolic Execution rules reducing the number of false positives.

False Negatives

  • 8493 - [C#] Fix S2583/S2589 FN and S2259 FP: Add support for relational pattern

False Positive

  • 7665 - [C#, VB.NET] Fix S2259 FP: is not and short-circuit or
  • 8382 - [C#, VB.NET] Fix S2589 FP: Custom Equals(null) is wrongly assumed to always return false
  • 8504 - [C#, VB.NET] Fix S1104 FP: Should be ignored on classes and structs marked as [Serializable]
Commits
  • e3e67e0 RSPEC update (#8553)
  • c7847c0 Add NuGet authentication (#8514)
  • 5decea0 Fix S1104 FN: In types marked as [Serializable], do not ignore fields marked ...
  • 20d4726 Happy New Year 2024! (#8530)
  • 53626ac Fix S1104 FP: Should be ignored on classes and structs marked as [Serializabl...
  • 2a9584d [TO BE REVERTED] Fix Maven IT Failures because of 'no plugins installed' (#8518)
  • 53de1b1 README: Add link for provisioning repo (#8516)
  • 2fb41a4 S3878: Add FP repro for #8510 (#8511)
  • 3ccd115 GitHub workflow: Improve author_association to NONE only (#8506)
  • 0420b6f Bump com.google.guava:guava from 32.1.3-jre to 33.0.0-jre (#8480)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @guibranco.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 9.16.0.82469 to 9.17.0.82934.
- [Release notes](https://github.com/SonarSource/sonar-dotnet/releases)
- [Commits](SonarSource/sonar-dotnet@9.16.0.82469...9.17.0.82934)

---
updated-dependencies:
- dependency-name: SonarAnalyzer.CSharp
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies Pull requests that update a dependency file nuget packages labels Jan 22, 2024
@dependabot dependabot bot requested a review from guibranco January 22, 2024 14:20
@guibranco guibranco enabled auto-merge (squash) January 22, 2024 14:21
Copy link
Owner

@guibranco guibranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automatically approved by gstraccini[bot]

@guibranco
Copy link
Owner

@dependabot squash and merge

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2024
Copy link

codacy-production bot commented Jan 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (25dd45f) 3378 1372 40.62%
Head commit (37342e8) 3378 (+0) 1372 (+0) 40.62% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#291) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@AppVeyorBot
Copy link

Build CrispyWaffle 4.3.297 completed (commit 89da9a682b by @dependabot[bot])

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (faaa37d) 37.43% compared to head (58ad7fb) 37.43%.
Report is 1 commits behind head on main.

❗ Current head 58ad7fb differs from pull request most recent head 73470a8. Consider uploading reports for the commit 73470a8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #291   +/-   ##
=======================================
  Coverage   37.43%   37.43%           
=======================================
  Files          71       71           
  Lines        3328     3328           
  Branches      467      467           
=======================================
  Hits         1246     1246           
  Misses       1997     1997           
  Partials       85       85           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

Copy link
Contributor Author

dependabot bot commented on behalf of github Jan 22, 2024

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

Copy link

codacy-production bot commented Jan 22, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.09%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d7972a5) 3330 1353 40.63%
Head commit (73470a8) 3330 (+0) 1356 (+3) 40.72% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#291) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@AppVeyorBot
Copy link

@guibranco guibranco merged commit 8b8cf44 into main Jan 23, 2024
21 of 23 checks passed
@guibranco guibranco deleted the dependabot/nuget/SonarAnalyzer.CSharp-9.17.0.82934 branch January 23, 2024 10:42
Copy link

sonarcloud bot commented Jan 23, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@AppVeyorBot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file .NET Pull requests that update .net code nuget packages size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants