Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silently ignores unrecognised options #745

Open
leonerd opened this issue May 18, 2022 · 1 comment
Open

Silently ignores unrecognised options #745

leonerd opened this issue May 18, 2022 · 1 comment

Comments

@leonerd
Copy link

leonerd commented May 18, 2022 

$ perlbrew install 5.28.0 --this-is-not-a-real-option
Fetching perl 5.28.0 as /home/leo/perl5/perlbrew/dists/perl-5.28.0.tar.gz
...

I would have expected an error.

This matters, because I just spent a while waiting on a bunch of perlbrew install --debugging to finish, and got very confused why I don't have debug-enabled perls. Turns out the option I wanted was --debug. It would have been nice for the unrecognised option name to complain, rather than be silently ignored.
@Leont
Copy link
Contributor

Leont commented May 18, 2022

Yeah, the return value of GetOptions should be checked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Leont @leonerd