Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve enforcement of tok constraint #99

Open
amir-zeldes opened this issue Oct 7, 2018 · 0 comments
Open

Improve enforcement of tok constraint #99

amir-zeldes opened this issue Oct 7, 2018 · 0 comments

Comments

@amir-zeldes
Copy link
Contributor

Currently spreadsheet mode assumes we have a tok column, by convention in spreadsheet column A. If this column does not exist, bugs crop up in various places, for example a key error in validation here:

https://github.com/gucorpling/gitdox/blob/dev/modules/validate_spreadsheet.py#L215

It might be better to either really assume that column A is tok (even if unlabeled), or to do something like this:

  • Look for a column named tok
  • If it's not found, throw a validation error but try assuming column A is tok instead of crashing
  • Regardless of the above operations, check that the tok column or column A if not found have no spans - if they have a span, report this and fail the validation check without crashing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant