diff --git a/common/app/conf/switches/ABTestSwitches.scala b/common/app/conf/switches/ABTestSwitches.scala index 6b7d5e058425..d9cc3fa0a0a3 100644 --- a/common/app/conf/switches/ABTestSwitches.scala +++ b/common/app/conf/switches/ABTestSwitches.scala @@ -55,16 +55,6 @@ trait ABTestSwitches { exposeClientSide = true, ) - Switch( - ABTests, - "ab-ads-in-merch", - "Test the commercial impact of showing adverts in merchandising-high and merchandising slots", - owners = Seq(Owner.withEmail("commercial.dev@theguardian.com")), - safeState = Off, - sellByDate = Some(LocalDate.of(2023, 11, 30)), - exposeClientSide = true, - ) - Switch( ABTests, "ab-elements-manager", diff --git a/common/app/conf/switches/CommercialSwitches.scala b/common/app/conf/switches/CommercialSwitches.scala index f1047d1ad559..e8cb410bde5d 100644 --- a/common/app/conf/switches/CommercialSwitches.scala +++ b/common/app/conf/switches/CommercialSwitches.scala @@ -1,5 +1,6 @@ package conf.switches +import java.time.LocalDate import conf.switches.Expiry.never import conf.switches.Owner.group import conf.switches.SwitchGroup.{Commercial, CommercialPrebid, Membership} @@ -431,4 +432,14 @@ trait PrebidSwitches { sellByDate = never, exposeClientSide = true, ) + + val adsInMerch: Switch = Switch( + group = Commercial, + name = "ads-in-merch", + description = "Enable showing adverts in merchandising-high and merchandising slots", + owners = group(Commercial), + safeState = Off, + sellByDate = Some(LocalDate.of(2023, 12, 4)), + exposeClientSide = true, + ) } diff --git a/static/src/javascripts/projects/common/modules/analytics/shouldCaptureMetrics.ts b/static/src/javascripts/projects/common/modules/analytics/shouldCaptureMetrics.ts index 053266a67177..725f428401dd 100644 --- a/static/src/javascripts/projects/common/modules/analytics/shouldCaptureMetrics.ts +++ b/static/src/javascripts/projects/common/modules/analytics/shouldCaptureMetrics.ts @@ -1,13 +1,11 @@ import type { ABTest } from '@guardian/ab-core'; import { getUrlVars } from 'lib/url'; import { isInABTestSynchronous } from '../experiments/ab'; -import { adsInMerch } from '../experiments/tests/ads-in-merch'; import { integrateIma } from '../experiments/tests/integrate-ima'; const defaultClientSideTests: ABTest[] = [ /* linter, please keep this array multi-line */ integrateIma, - adsInMerch, ]; /** diff --git a/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts b/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts index 922f51ef2857..657885f7e349 100644 --- a/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts +++ b/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts @@ -1,5 +1,4 @@ import type { ABTest } from '@guardian/ab-core'; -import { adsInMerch } from './tests/ads-in-merch'; import { consentlessAds } from './tests/consentlessAds'; import { deeplyReadArticleFooterTest } from './tests/deeply-read-article-footer'; import { elementsManager } from './tests/elements-manager'; @@ -18,7 +17,6 @@ export const concurrentTests: readonly ABTest[] = [ deeplyReadArticleFooterTest, consentlessAds, integrateIma, - adsInMerch, elementsManager, prebidKargo, ]; diff --git a/static/src/javascripts/projects/common/modules/experiments/tests/ads-in-merch.ts b/static/src/javascripts/projects/common/modules/experiments/tests/ads-in-merch.ts deleted file mode 100644 index 6e94c6dce349..000000000000 --- a/static/src/javascripts/projects/common/modules/experiments/tests/ads-in-merch.ts +++ /dev/null @@ -1,31 +0,0 @@ -import type { ABTest } from '@guardian/ab-core'; - -export const adsInMerch: ABTest = { - id: 'AdsInMerch', - author: '@commercial-dev', - start: '2022-12-07', - expiry: '2023-11-30', - // TODO increase audience size and set offset once we know desired sample size - audience: 0 / 100, - audienceOffset: 0 / 100, - audienceCriteria: 'Opt in only', - successMeasure: - 'Test the commercial impact of showing adverts in merchandising-high and merchandising slots', - description: - 'Show adverts in merchandising-high and merchandising slots to browsers in the variant', - variants: [ - { - id: 'control', - test: (): void => { - /* */ - }, - }, - { - id: 'variant', - test: (): void => { - /* */ - }, - }, - ], - canRun: () => true, -};