From 1e98bf5d80e8cbb333f6c31d721893a779f3426a Mon Sep 17 00:00:00 2001 From: Jake Lee Kennedy Date: Wed, 3 Apr 2024 15:18:57 +0100 Subject: [PATCH] Launch Commercial Q4 mega test at 0% (#27013) --- package.json | 2 +- .../common/modules/experiments/ab-tests.ts | 2 -- .../experiments/tests/section-ad-density.ts | 31 ------------------- yarn.lock | 8 ++--- 4 files changed, 5 insertions(+), 38 deletions(-) delete mode 100644 static/src/javascripts/projects/common/modules/experiments/tests/section-ad-density.ts diff --git a/package.json b/package.json index 554349c207f..dff9e86013d 100644 --- a/package.json +++ b/package.json @@ -17,7 +17,7 @@ "@guardian/ab-core": "^5.0.0", "@guardian/atom-renderer": "^2.0.0", "@guardian/automat-modules": "^0.3.8", - "@guardian/commercial": "17.7.0", + "@guardian/commercial": "17.8.0", "@guardian/consent-management-platform": "13.12.1", "@guardian/core-web-vitals": "^5.0.0", "@guardian/identity-auth": "2.1.0", diff --git a/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts b/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts index 6b2f04e3169..754c09da6f3 100644 --- a/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts +++ b/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts @@ -2,7 +2,6 @@ import type { ABTest } from '@guardian/ab-core'; import { blockSupporterRevenueMessagingSport } from './tests/block-supporter-revenue-messaging-sport'; import { mpuWhenNoEpic } from './tests/mpu-when-no-epic'; import { remoteRRHeaderLinksTest } from './tests/remote-header-test'; -import { sectionAdDensity } from './tests/section-ad-density'; import { signInGateAlternativeWording } from './tests/sign-in-gate-alternative-wording'; import { signInGateMainControl } from './tests/sign-in-gate-main-control'; import { signInGateMainVariant } from './tests/sign-in-gate-main-variant'; @@ -15,6 +14,5 @@ export const concurrentTests: readonly ABTest[] = [ signInGateAlternativeWording, remoteRRHeaderLinksTest, mpuWhenNoEpic, - sectionAdDensity, blockSupporterRevenueMessagingSport, ]; diff --git a/static/src/javascripts/projects/common/modules/experiments/tests/section-ad-density.ts b/static/src/javascripts/projects/common/modules/experiments/tests/section-ad-density.ts deleted file mode 100644 index dc7bbc6d4b9..00000000000 --- a/static/src/javascripts/projects/common/modules/experiments/tests/section-ad-density.ts +++ /dev/null @@ -1,31 +0,0 @@ -import type { ABTest } from '@guardian/ab-core'; - -export const sectionAdDensity: ABTest = { - id: 'SectionAdDensity', - author: '@commercial-dev', - start: '2024-03-07', - expiry: '2024-07-26', - audience: 5 / 100, - audienceOffset: 0 / 100, - audienceCriteria: - 'Article pages in the following sections: business, environment, music, money, artanddesign, science, stage, travel, wellness, games', - successMeasure: - 'Overall revenue increases without harming attention time and page views per session metrics.', - description: - 'Increase inline advert density on article pages in high value sections.', - variants: [ - { - id: 'control', - test: (): void => { - /* no-op */ - }, - }, - { - id: 'variant', - test: (): void => { - /* no-op */ - }, - }, - ], - canRun: () => true, -}; diff --git a/yarn.lock b/yarn.lock index 27e0a604674..405402b304c 100644 --- a/yarn.lock +++ b/yarn.lock @@ -2423,10 +2423,10 @@ react "^16.13.1" react-dom "^16.13.1" -"@guardian/commercial@17.7.0": - version "17.7.0" - resolved "https://registry.yarnpkg.com/@guardian/commercial/-/commercial-17.7.0.tgz#4adfe90dfabb23e37aa2ec5b491423f42c782c3b" - integrity sha512-/5CS301ReNNS9+k5N3t9zX2FscuRT+NmQVKAMLcQ+/bDB1B0P9wN6T8vPj0QueX9Rmi18894ycCjYXy2xcG+0Q== +"@guardian/commercial@17.8.0": + version "17.8.0" + resolved "https://registry.yarnpkg.com/@guardian/commercial/-/commercial-17.8.0.tgz#1aa3ac254146d5cbfb6253e7f2623119f4743290" + integrity sha512-h3KvoybpvPJOrzrKiSU0Vo09pKQ2OLQ20zqNTbteO5DLrtY0d+0B1qrW2+BjPPb+qCAyTrx6oMFCZrkeGooWBA== dependencies: "@changesets/cli" "^2.26.2" "@guardian/ophan-tracker-js" "2.0.4"