From 9671d3340d7258bf478623d81c26d00fbabfb167 Mon Sep 17 00:00:00 2001 From: Chris Jones Date: Wed, 29 Nov 2023 11:50:32 +0000 Subject: [PATCH 1/2] Delete GEM AB test switch --- common/app/conf/switches/ABTestSwitches.scala | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/common/app/conf/switches/ABTestSwitches.scala b/common/app/conf/switches/ABTestSwitches.scala index d9cc3fa0a0a..babee9ef876 100644 --- a/common/app/conf/switches/ABTestSwitches.scala +++ b/common/app/conf/switches/ABTestSwitches.scala @@ -55,16 +55,6 @@ trait ABTestSwitches { exposeClientSide = true, ) - Switch( - ABTests, - "ab-elements-manager", - "Test serving GEM assets in ad slots on page", - owners = Seq(Owner.withEmail("commercial.dev@theguardian.com")), - safeState = Off, - sellByDate = Some(LocalDate.of(2023, 11, 30)), - exposeClientSide = true, - ) - Switch( ABTests, "ab-prebid-kargo", From bef75b8a8a6e83b171bc3f7081ccf988964a5580 Mon Sep 17 00:00:00 2001 From: Chris Jones Date: Wed, 29 Nov 2023 11:50:41 +0000 Subject: [PATCH 2/2] Delete GEM AB test def --- .../common/modules/experiments/ab-tests.ts | 2 -- .../experiments/tests/elements-manager.ts | 19 ------------------- 2 files changed, 21 deletions(-) delete mode 100644 static/src/javascripts/projects/common/modules/experiments/tests/elements-manager.ts diff --git a/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts b/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts index 657885f7e34..d6b103cd6cc 100644 --- a/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts +++ b/static/src/javascripts/projects/common/modules/experiments/ab-tests.ts @@ -1,7 +1,6 @@ import type { ABTest } from '@guardian/ab-core'; import { consentlessAds } from './tests/consentlessAds'; import { deeplyReadArticleFooterTest } from './tests/deeply-read-article-footer'; -import { elementsManager } from './tests/elements-manager'; import { integrateIma } from './tests/integrate-ima'; import { prebidKargo } from './tests/prebid-kargo'; import { remoteRRHeaderLinksTest } from './tests/remote-header-test'; @@ -17,6 +16,5 @@ export const concurrentTests: readonly ABTest[] = [ deeplyReadArticleFooterTest, consentlessAds, integrateIma, - elementsManager, prebidKargo, ]; diff --git a/static/src/javascripts/projects/common/modules/experiments/tests/elements-manager.ts b/static/src/javascripts/projects/common/modules/experiments/tests/elements-manager.ts deleted file mode 100644 index 4b0f6240d3c..00000000000 --- a/static/src/javascripts/projects/common/modules/experiments/tests/elements-manager.ts +++ /dev/null @@ -1,19 +0,0 @@ -import type { ABTest } from '@guardian/ab-core'; -import { noop } from '../../../../../lib/noop'; - -export const elementsManager: ABTest = { - id: 'ElementsManager', - author: '@commercial-dev', - start: '2023-02-23', - expiry: '2023-06-30', - audience: 0 / 100, - audienceOffset: 0 / 100, - audienceCriteria: 'Opt in only', - successMeasure: 'Able to serve GEM assets in ad slots on page', - description: 'Test serving GEM assets in ad slots on page', - variants: [ - { id: 'control', test: noop }, - { id: 'variant', test: noop }, - ], - canRun: () => true, -};