From 2c96f12580c8cfc14c68b3833c8fc2387ff403c2 Mon Sep 17 00:00:00 2001 From: Jake Date: Mon, 2 Dec 2024 10:54:33 +0000 Subject: [PATCH 1/3] delete header bidding test switch (#27643) --- common/app/conf/switches/ABTestSwitches.scala | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/common/app/conf/switches/ABTestSwitches.scala b/common/app/conf/switches/ABTestSwitches.scala index 3a1af3732037..3f1c921eb30d 100644 --- a/common/app/conf/switches/ABTestSwitches.scala +++ b/common/app/conf/switches/ABTestSwitches.scala @@ -44,7 +44,7 @@ trait ABTestSwitches { "Test the Opt Out frequency capping feature", owners = Seq(Owner.withEmail("commercial.dev@theguardian.com")), safeState = Off, - sellByDate = Some(LocalDate.of(2024, 12, 2)), + sellByDate = Some(LocalDate.of(2025, 1, 29)), exposeClientSide = true, highImpact = false, ) @@ -71,16 +71,6 @@ trait ABTestSwitches { highImpact = false, ) - Switch( - ABTests, - "ab-new-header-bidding-endpoint", - "Test new header bidding (prebid) analytics endpoint", - owners = Seq(Owner.withEmail("commercial.dev@theguardian.com")), - safeState = Off, - sellByDate = Some(LocalDate.of(2024, 12, 2)), - exposeClientSide = true, - highImpact = false, - ) Switch( ABTests, "ab-gpid-prebid-ad-units", From 5a5dcc1070b236eaf3da72edcfbb4fb1f3d9bc87 Mon Sep 17 00:00:00 2001 From: Charlotte Emms <43961396+cemms1@users.noreply.github.com> Date: Mon, 2 Dec 2024 15:02:28 +0000 Subject: [PATCH 2/3] extend front container show/hide switch and reassin owner (#27645) --- common/app/conf/switches/FeatureSwitches.scala | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/common/app/conf/switches/FeatureSwitches.scala b/common/app/conf/switches/FeatureSwitches.scala index 99cd0c0565f5..7b3a2d5c49cb 100644 --- a/common/app/conf/switches/FeatureSwitches.scala +++ b/common/app/conf/switches/FeatureSwitches.scala @@ -567,9 +567,9 @@ trait FeatureSwitches { group = SwitchGroup.Feature, name = "disable-front-container-show-hide", description = "For users with no currently hidden containers on a front, removes the ability to hide containers", - owners = Seq(Owner.withGithub("cemms1")), + owners = Seq(Owner.withEmail("project.fairground@theguardian.com")), safeState = On, - sellByDate = LocalDate.of(2024, 11, 29), + sellByDate = LocalDate.of(2025, 2, 4), exposeClientSide = true, highImpact = false, ) From d26c0666d4bb96fbf3c66cde1ac410677a2d9b0e Mon Sep 17 00:00:00 2001 From: Frederick O'Brien Date: Tue, 3 Dec 2024 11:33:43 +0000 Subject: [PATCH 3/3] Add 'Climate crisis' link to US nav (#27646) * Add 'Climate crisis' link to US nav 'Environment' moved between 'Business' and 'Tech' * Update reference-navigation.json * Update reference-navigation.json --- common/app/navigation/NavLinks.scala | 3 +- .../test/resources/reference-navigation.json | 74 ++++++++++--------- 2 files changed, 42 insertions(+), 35 deletions(-) diff --git a/common/app/navigation/NavLinks.scala b/common/app/navigation/NavLinks.scala index 37473d158f87..f5bc9fc3215c 100644 --- a/common/app/navigation/NavLinks.scala +++ b/common/app/navigation/NavLinks.scala @@ -319,11 +319,12 @@ object NavLinks { usNews, usPolitics, world, - usEnvironment, + climateCrisis, middleEast, ukraine, usSoccer, usBusiness, + usEnvironment, usTech, science, newsletters, diff --git a/common/test/resources/reference-navigation.json b/common/test/resources/reference-navigation.json index c01ea6a36117..ac236950a81e 100644 --- a/common/test/resources/reference-navigation.json +++ b/common/test/resources/reference-navigation.json @@ -1070,40 +1070,9 @@ "classList": [] }, { - "title": "Environment", - "url": "/us/environment", - "children": [ - { - "title": "Climate crisis", - "url": "/environment/climate-crisis", - "children": [], - "classList": [] - }, - { - "title": "Wildlife", - "url": "/environment/wildlife", - "children": [], - "classList": [] - }, - { - "title": "Energy", - "url": "/environment/energy", - "children": [], - "classList": [] - }, - { - "title": "Pollution", - "url": "/environment/pollution", - "children": [], - "classList": [] - }, - { - "title": "Green light", - "url": "/environment/series/green-light", - "children": [], - "classList": [] - } - ], + "title": "Climate crisis", + "url": "/environment/climate-crisis", + "children": [], "classList": [] }, { @@ -1198,6 +1167,43 @@ ], "classList": [] }, + { + "title": "Environment", + "url": "/us/environment", + "children": [ + { + "title": "Climate crisis", + "url": "/environment/climate-crisis", + "children": [], + "classList": [] + }, + { + "title": "Wildlife", + "url": "/environment/wildlife", + "children": [], + "classList": [] + }, + { + "title": "Energy", + "url": "/environment/energy", + "children": [], + "classList": [] + }, + { + "title": "Pollution", + "url": "/environment/pollution", + "children": [], + "classList": [] + }, + { + "title": "Green light", + "url": "/environment/series/green-light", + "children": [], + "classList": [] + } + ], + "classList": [] + }, { "title": "Tech", "url": "/us/technology",