Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer dependencies mismatch #6945

Closed
4 of 5 tasks
mxdvl opened this issue Jan 12, 2023 · 2 comments
Closed
4 of 5 tasks

Peer dependencies mismatch #6945

mxdvl opened this issue Jan 12, 2023 · 2 comments
Labels
DCR Dependency Dependency for DCR project Dependencies Pull requests that update a dependency file dotcom-rendering Epic
Milestone

Comments

@mxdvl
Copy link
Contributor

mxdvl commented Jan 12, 2023

Current peer dependencies mismatch

We want to enforce met peer dependencies for @guardian/* packages

Tasks

  1. Dependencies
    emma-imber
  2. Dependencies
    tjmw
  3. Dependencies
    coldlink
  4. Dependencies
    sookburt
@mxdvl mxdvl added Dependencies Pull requests that update a dependency file DCR Dependency Dependency for DCR project dotcom-rendering labels Jan 12, 2023
mxdvl added a commit that referenced this issue Jan 12, 2023
this allows tracking of current peer dependencies mismatches
for all three workspaces in the following issue:

#6945
@OllysCoding OllysCoding pinned this issue Jan 12, 2023
@cemms1
Copy link
Contributor

cemms1 commented Jan 15, 2024

Output from running pnpm install --resolution-only:

WARN  Issues with peer dependencies found
dotcom-rendering
├─┬ @guardian/braze-components 16.3.0
│ ├── ✕ unmet peer @guardian/libs@^15.1.0: found 16.0.0
│ ├── ✕ unmet peer @guardian/source-foundations@^12.0.0: found 14.1.2
│ ├── ✕ unmet peer @guardian/source-react-components@^15.0.1: found 18.0.0
│ └── ✕ unmet peer @guardian/source-react-components-development-kitchen@^13.0.1: found 16.0.0
├─┬ @guardian/commercial 11.32.1
│ ├── ✕ unmet peer @guardian/libs@^15.6.4: found 16.0.0
│ ├── ✕ unmet peer @guardian/source-foundations@^13.0.0: found 14.1.2
│ ├── ✕ unmet peer @guardian/ab-core@^5.0.0: found 7.0.1
│ ├── ✕ unmet peer @guardian/core-web-vitals@^5.1.0: found 6.0.0
│ └─┬ prebid.js 8.24.0
│   └─┬ @guardian/libs 15.7.1
│     └── ✕ unmet peer typescript@~5.1.3: found 5.3.3
├─┬ @guardian/consent-management-platform 13.7.1
│ └── ✕ unmet peer @guardian/libs@^15.0.0: found 16.0.0
├─┬ @guardian/identity-auth 1.1.0
│ ├── ✕ unmet peer @guardian/libs@^15.0.0: found 16.0.0
│ └── ✕ unmet peer typescript@~5.1.3: found 5.3.3
└─┬ @guardian/identity-auth-frontend 1.0.0
  ├── ✕ unmet peer @guardian/libs@^15.0.0: found 16.0.0
  └── ✕ unmet peer typescript@~5.1.3: found 5.3.3

@mxdvl mxdvl added this to WebX Team Jan 15, 2024
@github-project-automation github-project-automation bot moved this to Triage in WebX Team Jan 15, 2024
@mxdvl mxdvl moved this from Triage to In Progress in WebX Team Jan 15, 2024
@mxdvl mxdvl added this to the Health milestone Jan 15, 2024
@georgeblahblah georgeblahblah moved this from In Progress to Blocked in WebX Team Jan 23, 2024
@alinaboghiu alinaboghiu moved this from Blocked to Backlog in WebX Team Jan 23, 2024
@mxdvl
Copy link
Contributor Author

mxdvl commented Apr 24, 2024

dotcom-rendering
├─┬ @guardian/braze-components 18.1.0
│ ├── ✕ unmet peer @guardian/source-react-components@^18.0.0: found 22.0.1
│ └── ✕ unmet peer @guardian/source-react-components-development-kitchen@^16.0.0: found 19.0.0
├─┬ @guardian/commercial 17.12.0
│ └── ✕ unmet peer @guardian/support-dotcom-components@^1.0.7: found 2.1.0
└─┬ @storybook/react-webpack5 7.6.17
  └─┬ @storybook/preset-react-webpack 7.6.17
    └─┬ @pmmmwh/react-refresh-webpack-plugin 0.5.11
      └── ✕ unmet peer webpack-dev-server@"3.x || 4.x": found 5.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DCR Dependency Dependency for DCR project Dependencies Pull requests that update a dependency file dotcom-rendering Epic
Projects
Archived in project
Development

No branches or pull requests

3 participants