Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split fixtures into DCRArticle and FEArticle #10883

Closed
4 tasks done
arelra opened this issue Mar 8, 2024 · 0 comments · Fixed by #10864
Closed
4 tasks done

Split fixtures into DCRArticle and FEArticle #10883

arelra opened this issue Mar 8, 2024 · 0 comments · Fixed by #10864
Assignees
Milestone

Comments

@arelra
Copy link
Member

arelra commented Mar 8, 2024

Completed by #10864

As part of the gen-fixtures script we currently output articles using the enhanced DCRArticle type. However Playwright tests expect the FEArticle type to POST to DCR.

This currently works as the DCRArticle type extends the FEArticle type but from #10801 the types will diverge.

Re-generating the fixtures has highlighted a few issues:

@arelra arelra added this to WebX Team Mar 8, 2024
@arelra arelra converted this from a draft issue Mar 8, 2024
@arelra arelra self-assigned this Mar 8, 2024
@arelra arelra added this to the Health milestone Mar 8, 2024
@arelra arelra moved this from In Progress to Review in WebX Team Mar 11, 2024
@JamieB-gu JamieB-gu linked a pull request Mar 12, 2024 that will close this issue
@shesah shesah moved this from Review to In Progress in WebX Team Mar 14, 2024
@shesah shesah moved this from In Progress to Blocked in WebX Team Mar 14, 2024
@arelra arelra moved this from Blocked to In Progress in WebX Team Mar 19, 2024
@JamieB-gu JamieB-gu moved this from In Progress to Review in WebX Team Mar 25, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in WebX Team Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant