-
Notifications
You must be signed in to change notification settings - Fork 30
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #6946 from guardian/mxdvl/peer-dependencies
- Loading branch information
Showing
3 changed files
with
125 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,113 @@ | ||
import { octokit } from './github.ts'; | ||
|
||
const peers = async (cwd: string) => { | ||
const process = Deno.run({ | ||
cwd, | ||
cmd: ['yarn', '--force'], | ||
stdout: 'null', | ||
stderr: 'piped', | ||
}); | ||
|
||
const [{ code }, rawOutput] = await Promise.all([ | ||
process.status(), | ||
process.stderrOutput(), | ||
]); | ||
|
||
if (code !== 0) Deno.exit(code); | ||
|
||
const deps = new TextDecoder() | ||
.decode(rawOutput) | ||
.split('\n') | ||
// keep only incorrect peer dependencies warnings | ||
.filter((line) => line.includes('has incorrect peer dependency')) | ||
// strip out the workspace-aggregator-xyz-012 prefixes | ||
.map((line) => line.replace(/workspace-aggregator-[a-z0-9-]+ > /, '')) | ||
// apps-rendering are not part of the workspace | ||
.map((line) => line.replace('" >', '"@guardian/apps-rendering >')); | ||
|
||
return deps; | ||
}; | ||
|
||
type Workspaces = { dcr: string[]; cr: string[]; ar: string[] }; | ||
const initialValue: Workspaces = { dcr: [], cr: [], ar: [] }; | ||
|
||
const { dcr, ar, cr } = ( | ||
await Promise.all(['.', './apps-rendering'].map(peers)) | ||
) | ||
.flat() | ||
.map((line) => { | ||
const matches = line.match( | ||
/warning "(.*?) > (.+?)" has incorrect peer dependency "(.+)"./, | ||
); | ||
if (!matches) throw new Error('Invalid string'); | ||
|
||
const [, workspace, dependency, peer] = matches; | ||
|
||
return { workspace, dependency, peer }; | ||
}) | ||
.reduce<Workspaces>((acc, { workspace, dependency, peer }) => { | ||
const line = `- [ ] \`${dependency}\` requires peer \`${peer}\``; | ||
switch (workspace) { | ||
case '@guardian/dotcom-rendering': | ||
return { | ||
...acc, | ||
dcr: acc.dcr.concat(line), | ||
}; | ||
|
||
case '@guardian/common-rendering': | ||
return { | ||
...acc, | ||
cr: acc.cr.concat(line), | ||
}; | ||
|
||
case '@guardian/apps-rendering': | ||
return { | ||
...acc, | ||
ar: acc.ar.concat(line), | ||
}; | ||
default: | ||
return acc; | ||
} | ||
}, initialValue); | ||
|
||
const body = `## Current peer dependencies mismatch | ||
### dotcom-rendering | ||
${dcr.length ? dcr.join('\n') : '- [X] all peer deps matched!'} | ||
### apps-rendering | ||
${ar.length ? ar.join('\n') : '- [X] all peer deps matched!'} | ||
### common-rendering | ||
${cr.length ? cr.join('\n') : '- [X] all peer deps matched!'} | ||
`; | ||
|
||
if (!octokit) { | ||
console.log(body); | ||
Deno.exit(); | ||
} | ||
|
||
/** https://github.com/guardian/dotcom-rendering/issues/6945 */ | ||
const issue_number = 6945; | ||
|
||
try { | ||
const { | ||
data: { html_url }, | ||
} = await octokit.rest.issues.update({ | ||
owner: 'guardian', | ||
repo: 'dotcom-rendering', | ||
issue_number, | ||
body, | ||
}); | ||
|
||
console.info(`Updated list of issues for dotcom-rendering#${issue_number}`); | ||
console.info(html_url); | ||
} catch (error) { | ||
// do_something | ||
console.warn(`Failed to update issue #${issue_number}`); | ||
console.error(error); | ||
|
||
console.log(body); | ||
} | ||
|
||
Deno.exit(); |