From 062cc93a4ec2848c2bff99a0fd902e1e604a99cc Mon Sep 17 00:00:00 2001 From: Marjan Kalanaki Date: Mon, 18 Nov 2024 09:21:21 +0000 Subject: [PATCH 1/5] add Carousel service and setCarouselInteraction function --- thrift/native.thrift | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/thrift/native.thrift b/thrift/native.thrift index 0788abd..bd1d7a1 100644 --- a/thrift/native.thrift +++ b/thrift/native.thrift @@ -196,3 +196,12 @@ service Navigation { service Newsletters { bool requestSignUp(1: string emailAddress, 2:string newsletterIdentityName) } + +service Carousel { + /** + * Notify the native layer that the user has started or stopped interacting with the carousel. + * + * @param isTouching true if the user has started touching the carousel, false otherwise + */ + void setCarouselInteraction(1:bool isTouching) +} From 490252cfbe6a7857e133b4f84c9c21a6c8cfef05 Mon Sep 17 00:00:00 2001 From: Marjan Kalanaki Date: Mon, 18 Nov 2024 18:14:56 +0000 Subject: [PATCH 2/5] update touch event function name --- thrift/native.thrift | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/thrift/native.thrift b/thrift/native.thrift index bd1d7a1..ab13ab8 100644 --- a/thrift/native.thrift +++ b/thrift/native.thrift @@ -197,11 +197,11 @@ service Newsletters { bool requestSignUp(1: string emailAddress, 2:string newsletterIdentityName) } -service Carousel { +service Touch { /** - * Notify the native layer that the user has started or stopped interacting with the carousel. + * Notify the native layer that the user has started or stopped touching. * - * @param isTouching true if the user has started touching the carousel, false otherwise + * @param isTouching true if the user has started touching, false otherwise */ - void setCarouselInteraction(1:bool isTouching) + void setIsTouching(1:bool isTouching) } From 1cbfc35712ecc739e428799fcc49aecd9a82cd34 Mon Sep 17 00:00:00 2001 From: Marjan Kalanaki Date: Fri, 22 Nov 2024 10:16:04 +0000 Subject: [PATCH 3/5] rename the service and fucntion for disabling the article swipe in native apps --- thrift/native.thrift | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/thrift/native.thrift b/thrift/native.thrift index ab13ab8..0d4dbe9 100644 --- a/thrift/native.thrift +++ b/thrift/native.thrift @@ -197,11 +197,11 @@ service Newsletters { bool requestSignUp(1: string emailAddress, 2:string newsletterIdentityName) } -service Touch { +service Interaction { /** - * Notify the native layer that the user has started or stopped touching. + * Notify the native layer to disable the article swipe feature. * - * @param isTouching true if the user has started touching, false otherwise + * @param disableSwipe true if native needs to disable article swipe */ - void setIsTouching(1:bool isTouching) + void disableArticleSwipe(1:bool disableSwipe) } From 99bba5dbc46edf4d1174aee13e7d5dcb8aceb4c5 Mon Sep 17 00:00:00 2001 From: Marjan Kalanaki Date: Mon, 25 Nov 2024 11:33:13 +0000 Subject: [PATCH 4/5] update package lock to bridget version 8 --- package-lock.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index 9524c85..e71b93e 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,12 +1,12 @@ { "name": "bridget", - "version": "7.0.0", + "version": "8.0.0", "lockfileVersion": 2, "requires": true, "packages": { "": { "name": "bridget", - "version": "7.0.0", + "version": "8.0.0", "license": "Apache-2.0", "devDependencies": { "@changesets/cli": "2.27.9", From bc1eda3ce83e98186d8751fa3cae493e40909b70 Mon Sep 17 00:00:00 2001 From: Marjan Kalanaki Date: Mon, 25 Nov 2024 11:33:39 +0000 Subject: [PATCH 5/5] changeset --- .changeset/cyan-months-battle.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/cyan-months-battle.md diff --git a/.changeset/cyan-months-battle.md b/.changeset/cyan-months-battle.md new file mode 100644 index 0000000..968dc5d --- /dev/null +++ b/.changeset/cyan-months-battle.md @@ -0,0 +1,5 @@ +--- +"bridget": minor +--- + +Add Service Interaction and disableArticleSwipe function