Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo vet infrastructure #1509

Open
sdroege opened this issue Sep 16, 2024 · 6 comments
Open

Add cargo vet infrastructure #1509

sdroege opened this issue Sep 16, 2024 · 6 comments

Comments

@sdroege
Copy link
Member

sdroege commented Sep 16, 2024

See gtk-rs/release#196

@swsnr
Copy link
Contributor

swsnr commented Oct 27, 2024

Out of curiosity, I attempted to run cargo-vet on an app of mine, which quickly got me down the rabbit hole of reviews on a huge audit backlog. To assess the scope for gtk-rs independently, I set up a small demo repo with gtk4, libadwaita, and gettext-rs and got started on cargo-vet.

It's not great, but it's not too bad either.

gtk-rs has a non-trivial dependency tree, and cargo vet initially reports about 1.2 million LoC for review. Importing the standard audit databases (google, mozilla, bytecode alliance, and embark studios) got it down to about 400k, and trusting a few high profile individuals which are also trusted by at least mozilla gets it down to just about 28k lines.

If you consider that much of that is licenses, docs, etc. and that reviewing for safe-to-run should be sufficient for desktop apps, this sounds doable, doesn't it?

@sdroege
Copy link
Member Author

sdroege commented Oct 29, 2024

Very doable, yes. Just needs to be done :)

@swsnr
Copy link
Contributor

swsnr commented Oct 29, 2024

So, what's the next step? Make a pull request to add cargo vet to this repo and thus make reviews mandatory for dependency updates?

@sdroege
Copy link
Member Author

sdroege commented Oct 29, 2024

Yes. See how it was done in the linked issue to get an idea

@swsnr
Copy link
Contributor

swsnr commented Oct 29, 2024

Mh, which linked issue are you referring to precisely? I only see a ticket in gtk-rs/release but there wasn't anything done over there 🤔

@sdroege
Copy link
Member Author

sdroege commented Oct 29, 2024

https://gitlab.gnome.org/Teams/Releng/rust-supply-chain is linked from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants