Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new AdwAboutDialog #68

Open
prateekmedia opened this issue Jul 15, 2022 · 10 comments
Open

Implement the new AdwAboutDialog #68

prateekmedia opened this issue Jul 15, 2022 · 10 comments

Comments

@prateekmedia
Copy link
Member

prateekmedia commented Jul 15, 2022

Design:
about-dialog-detailed

After Implementation:

@simrat39
Copy link
Member

simrat39 commented Aug 5, 2022

I can take this on, but from my testing on the adwaita test app, this is just a new window, not a dialog which cant leave the app, so I'm not sure if we should implement it as a dialog or not

@prateekmedia
Copy link
Member Author

Yes but implementing it as a Window would not be a easy task may need to use multi window packages from pub.dev

@simrat39
Copy link
Member

simrat39 commented Aug 9, 2022

Yeah ill just stick to a normal dialog, don't think anyone wants to move it out of the main window anyways

@simrat39
Copy link
Member

simrat39 commented Aug 9, 2022

Looks like we already have something similar https://github.com/gtk-flutter/libadwaita/blob/main/lib/src/widgets/adw/about_window.dart, or is there any difference?

@prateekmedia
Copy link
Member Author

prateekmedia commented Aug 9, 2022

We already have but it's not that feature rich, as It was create before the about window was merged.

Like we don't have credits, legal or acknowledgement section as shown in above Gnome Builder pics.

Although we don't need all sub categories but we need some kind of way for developers to add it

Also current about dialog doesn't have animation when navigating inside the dialog

@simrat39
Copy link
Member

simrat39 commented Aug 9, 2022

Ok sounds good, so I just extend that widget then right

@prateekmedia
Copy link
Member Author

Yes that would work

@simrat39
Copy link
Member

simrat39 commented Aug 9, 2022

adw_aboot_demo

Got this much done, will continue working on it tomorrow

@prateekmedia
Copy link
Member Author

Wow, looks great. Animation look cool.

@Henry-Hiles
Copy link

adw_aboot_demo adw_aboot_demo

Got this much done, will continue working on it tomorrow

looks very cool, is this done now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants