Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V2 RoadMap #22

Open
3 of 4 tasks
gs-akhan opened this issue May 13, 2017 · 41 comments
Open
3 of 4 tasks

V2 RoadMap #22

gs-akhan opened this issue May 13, 2017 · 41 comments
Labels
enhancement

Comments

@gs-akhan
Copy link
Owner

gs-akhan commented May 13, 2017 •
edited
Loading

Hi, These are the features being targeted for V2

  • Multiple Selection - Allowing users to multiselect options. Just like ...
  • as option - Allowing to pass Views to options, this will allow users to have icons inside options
  • Slide the selection menu from Top or Bottom of screen ..
  • Searching options.
    @Stoffern @technology-studio-apiary

Thanks
@st0ffern
Copy link
Collaborator

How about a dropdown instead of a modal overlay?

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 13, 2017 •
edited
Loading

Yeah Good question. But positioning is one hell of thing.
I have contributed at lot to https://github.com/alinz/react-native-dropdown.

But the problem is when we embed the component inside navigator or otherviews the top and left positions are relative to parent component.
So what I thought is to have a complete view for selection. It is easy UX wise too and also coding wise.

We can have that options too, if we collectively decide.

@rostislav-simonik
Copy link
Contributor

rostislav-simonik commented May 15, 2017 •
edited
Loading

@gs-akhan Have you had chance to validate my sample for setSelectedText #20 alternative through props ? Would you like me to create pull request for given approach?

@st0ffern
Copy link
Collaborator

@gs-akhan i will fix v2 by this week, just need to land a few things @ work

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 15, 2017 via email

@gs-akhan
Copy link
Owner Author

@rostislav-simonik I havent. will do it tonight.

@rostislav-simonik
Copy link
Contributor

rostislav-simonik commented May 15, 2017 •
edited
Loading

@gs-akhan Ok, thanks, let me know then and I'll do a more clean proposal.

@st0ffern
Copy link
Collaborator

@gs-akhan can you add me as collaborator on NPM?
Also activate Travis on the repo 😉

I am starting with v2 now

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 21, 2017 via email

@gs-akhan
Copy link
Owner Author

@Stoffern What's your NPM profile name ?

@st0ffern
Copy link
Collaborator

https://www.npmjs.com/~stoffern

@st0ffern
Copy link
Collaborator

st0ffern commented May 21, 2017 •
edited
Loading

added
direction (fromLeft, fromRight, fromTop, fromBottom)
and
renderButton={ currentValue => <Text>{'Current Value: ' + currentValue}</Text> }

more to come later on v2

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 21, 2017 via email

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 21, 2017 via email

@st0ffern
Copy link
Collaborator

st0ffern commented May 21, 2017 •
edited
Loading

i feed we should remove sending styles into the Select and rather let the user send custom components into it with styles..

This is for SelectButton and Options

@st0ffern
Copy link
Collaborator

passing it like this:

renderButton={ currentValue => <Text>{'Current Value: ' + currentValue}</Text> }
renderOptionItem = { ({value, text, index}) => <View key={index} style={{}}>{text}</View>}
renderOptionSeperator={ data => <View style={{height: 1, backgroundColor: 'black'}}></View>}

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 21, 2017 via email

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 21, 2017 via email

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 21, 2017 via email

@st0ffern
Copy link
Collaborator

st0ffern commented May 21, 2017 •
edited
Loading

It's a normal practise to do in React. Look at ListView and FlatList
I think if you dont pass in a custom component it will just render default layout..

So it is optional

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 21, 2017 via email

@rostislav-simonik
Copy link
Contributor

rostislav-simonik commented May 22, 2017 •
edited
Loading

@gs-akhan @Stoffern Hi guys, what about the change I have been proposing. The one which substitutes setSelectedText with props logic?

@st0ffern
Copy link
Collaborator

@rostislav-simonik i am rewriting the Select totally, into v2.
There will be no setSelectText 😉

@st0ffern
Copy link
Collaborator

st0ffern commented May 22, 2017 •
edited
Loading

@gs-akhan how do you want to solve the multiple select?
What should the user do after he has selected multiple items in order to confirm selections?

@gs-akhan
Copy link
Owner Author

@rostislav-simonik Yeaah your concerns are taken care by @Stoffern 's fix.

@Stoffern
So the API for multiselect should be based of prop multiple = true just like we have in HTML Select tag.

And selected values should be as array of options selected.

@st0ffern
Copy link
Collaborator

Yes, but when is the user done selecting?

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 22, 2017 via email

@st0ffern
Copy link
Collaborator

Then er need a "done" button?

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 22, 2017 via email

@st0ffern
Copy link
Collaborator

done

@st0ffern
Copy link
Collaborator

st0ffern commented May 22, 2017 •
edited
Loading

I think "Searching options" should be a v3..
Lets keep changes to a minimum in v2 and making it compatible for upgrades..

There are breaking changes in v2, but they are also taking future updates into conciderations so they will not be breaking later on.
cc @gs-akhan

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 22, 2017 via email

@st0ffern
Copy link
Collaborator

yup, needs some testing..
I will fix Travis testings and README.md + MIGRATION.md later today

@gs-akhan
Copy link
Owner Author

gs-akhan commented May 22, 2017 via email

@rtman
Copy link

rtman commented Aug 17, 2017

@gs-akhan I realize this is a few months old by now but do you still have plans to release v2?

@gs-akhan
Copy link
Owner Author

@rtman Yes we would like you. The thing is we need some beta testers who can validate if its working well. If you wish to help it. we can make a release.

Thanks

@rtman
Copy link

rtman commented Aug 19, 2017

@gs-akhan
Hey I'm willing to test it in my app, I can't guarantee I can help too much in any debug but I can report what is happening. My time is a bit limited at the moment since I am developing full time with a deadline looming.

@gs-akhan
Copy link
Owner Author

@rtman Absolutely yes sir. :)

@st0ffern
Copy link
Collaborator

Back from a longer vacation 😉 what is the status of v2 ? 😄

@st0ffern
Copy link
Collaborator

st0ffern commented Dec 8, 2017

Should i continue on this one?

@gs-akhan
Copy link
Owner Author

gs-akhan commented Dec 8, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@st0ffern @gs-akhan @rtman @rostislav-simonik