Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of redirected input #3451

Merged
merged 6 commits into from
Oct 3, 2024
Merged

Handling of redirected input #3451

merged 6 commits into from
Oct 3, 2024

Conversation

denis256
Copy link
Member

@denis256 denis256 commented Oct 2, 2024

Description

Included changes:

  • added check for available terminal
  • improved signaling of stdout reading termination

Adding a test for this case is challenging since all tests are executed in non-interactive shell.

Before:
image

After:

image

Fixes #3450.

TODOs

Read the Gruntwork contribution guidelines.

  • Update the docs.
  • Run the relevant tests successfully, including pre-commit checks.
  • Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
  • Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Fixed handling of input from console redirection.

Migration Guide

@denis256 denis256 marked this pull request as ready for review October 2, 2024 21:57
@denis256 denis256 merged commit 3dad994 into main Oct 3, 2024
5 checks passed
@denis256 denis256 deleted the input-forward-3450 branch October 3, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't run console command in non-interactive mode
2 participants