Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds a Github link on the API page's sidebar #148

Closed
wants to merge 1 commit into from
Closed

Adds a Github link on the API page's sidebar #148

wants to merge 1 commit into from

Conversation

leobalter
Copy link
Member

Fixes #137

leobalter
leobalter reviewed Sep 25, 2014
View reviewed changes
tasks/docs.js
name: 'Github',
url: 'https://github.com/gruntjs/',
external: true
});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not the better implementation, but inserting entries on the docs with external urls would require some over optimization. I can try to do that too, it would just require more time.

@JKVeganAbroad
Copy link
Contributor

I really like your code optimisations in /src/tmpl/docs.jade. It's much more readable now.

You're critical about pushing Github as an external link, but I thought that was elegant.

BTW, shouldn't GitHub have a capital "H"?

As I'm yet to understand how this site is compiled, I don't fully understand what your code is doing, so I'll call on a friend to see if we can merge or close this PR . . . @vladikoff 😅

@leobalter
Copy link
Member Author

I'm sorry for the delay answering this. I'll clean this soon as it's the single remaining PR :)

shouldn't GitHub have a capital "H"?

yes! I fixed this on a rebased commit.

@vladikoff vladikoff closed this Jul 19, 2016
@XhmikosR
Copy link
Member

@vladikoff: was this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Github link on the API page's sidebar
4 participants
@leobalter @JKVeganAbroad @XhmikosR @vladikoff