Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass through the allowHttp1 option for fallback HTTP/2 to HTTP/1 #296

Open
jasonmobley opened this issue Nov 18, 2024 · 0 comments
Open

Comments

@jasonmobley
Copy link

jasonmobley commented Nov 18, 2024

In the spot where createSecureServer is called, can it include the allowHttp1 option so that a "http2" protocol server still functions for clients that don't load with HTTP/2?

Without this, a misbehaving client gets a response like:

Missing ALPN Protocol, expected h2 to be available.
If this is a HTTP request: The server was not configured with the allowHTTP1 option or a listener for the unknownProtocol event.

Relevant NodeJS docs: https://nodejs.org/api/http2.html#http2createsecureserveroptions-onrequesthandler

edit: this is specifically in versions >=5.0.0 where the http2 stuff was recently updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant