Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdsclient/test: use separate channels in test watchers for error, update and resource not exist #7864

Open
purnesh42H opened this issue Nov 21, 2024 · 0 comments
Assignees
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Type: Bug

Comments

@purnesh42H
Copy link
Contributor

The current end-to-end tests for xdsclient utilize a watcher implementation with a channel size of 1. This limitation prevents us from testing scenarios involving multiple updates with a combination of errors and successful updates.

To overcome this, we should modify the test watcher implementations to incorporate three separate channels:

  • Update Channel: For successful updates
  • Error Channel: For error updates
  • Resource Not Found Channel: For "resource not found" updates

Each channel should have a configurable size, allowing tests to adjust it as needed. This enhancement will enable comprehensive testing of various update scenarios, including those with mixed successes and failures.

@purnesh42H purnesh42H added Type: Bug Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Nov 21, 2024
@purnesh42H purnesh42H self-assigned this Nov 21, 2024
@purnesh42H purnesh42H added the P2 label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Type: Bug
Projects
None yet
Development

No branches or pull requests

1 participant