Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong number of clock cycles during low ST #1

Open
rbcarlos opened this issue Jun 26, 2018 · 3 comments
Open

Wrong number of clock cycles during low ST #1

rbcarlos opened this issue Jun 26, 2018 · 3 comments

Comments

@rbcarlos
Copy link

Hello,
I found out that in your code there is an incorrect number of clock cycles during low ST.
There should be 87 cycles before the sensor starts outputting data, but in your code, it is only 86 (85 in loop + 1 outside).

@mmp97
Copy link

mmp97 commented Jan 19, 2022

Hei!
Thats exactly what I've found. I was wondering where does this number of cycles come from. Thanks for pointing this out. Btw. as oof 2022, the issue still has not been resolved.

@cheno85
Copy link

cheno85 commented May 19, 2022

Hi, I noticed that the code has 87, it might have been edited recently... the code worked for me as is

@jdesbonnet
Copy link

jdesbonnet commented Mar 4, 2024

I agree that this doesn't look right. Looking at the spectrometer output with "i < 85" in the loop the first 2 'pixels' read are discontinuous with the rest of the spectrum. Ie 137, 135, 383, 373, 360 ... (full spectrum below).

I wonder should it actually be "i < 87" in the loop because it looks like there are two dark pixels at the start.

This wouldn't be noticed if you were doing your own calibration. But if you're using the calibration sheets provided on the GroupGets website then you'd be off by two pixels which would be an error of +3.4nm

137,134,383,373,360,347,341,330,323,316,303,299,293,283,277,274,269,262,254,252,250,241,246,238,242,247,230,231,236,222,229,224,227,226,222,224,224,221,219,218,220,227,218,213,215,220,212,215,210,213,214,218,215,207,212,211,209,210,210,210,207,203,208,206,207,211,206,208,211,211,210,208,211,212,211,213,216,213,215,215,216,220,213,213,217,215,214,218,216,218,218,216,222,219,220,223,222,218,218,221,224,220,217,223,220,219,216,217,216,219,221,220,218,217,216,214,215,216,218,218,217,220,219,219,222,215,216,222,219,220,220,218,219,219,222,220,221,223,221,221,217,219,222,223,219,224,222,225,227,231,231,239,237,235,231,236,240,240,241,247,246,250,250,252,275,263,266,269,271,281,280,285,291,289,296,301,304,308,315,315,328,335,336,340,349,359,365,369,382,390,400,402,407,415,421,434,442,447,461,465,478,494,497,495,513,521,530,528,532,546,544,546,546,546,557,557,561,565,565,572,580,578,592,573,583,591,587,590,595,591,594,588,591,596,596,592,598,593,609,600,599,604,599,600,606,606,604,604,603,608,596,606,599,588,598,598,592,589,587,587,587,588,587,587,581,584,578,581,587,576,580,578,572,580,576,576,573,566,571,568,560,564,560,559,557,553,551,549,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants