diff --git a/CHANGELOG.md b/CHANGELOG.md index e232a1f..17d14ad 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,13 +4,12 @@ All notable changes to this project will be documented in this file. ## [0.0.1-RC8] -- LeiaElasticBundle: Fixes the override for adding ElasticHealthCheck -- Removed the unused `LeiaCompiledPath` class - SchemaDetails: - Moved the nested `SchemaKey` attributes to the class level - made the getReferenceId() uniform with `SchemaKey` implementation - FieldUtils: Excluding non-serializable fields(static, transient, @JsonIgnore) for building the schema attributes - SchemaResource: Bug fix in SchemaValidation resource +- Removed the unused `LeiaCompiledPath` class ## [0.0.1-RC7] diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md new file mode 100644 index 0000000..00334bf --- /dev/null +++ b/CONTRIBUTORS.md @@ -0,0 +1,6 @@ +### Contributors + +* [Koushik R](https://github.com/koushikr) +* [Abhishek](https://github.com/abhigun) +* [Subham](https://github.com/nullsoni) + diff --git a/leia-models/src/main/java/com/grookage/leia/models/request/ValidateSchemaRequest.java b/leia-models/src/main/java/com/grookage/leia/models/request/ValidateSchemaRequest.java index d31ac95..72c0a6a 100644 --- a/leia-models/src/main/java/com/grookage/leia/models/request/ValidateSchemaRequest.java +++ b/leia-models/src/main/java/com/grookage/leia/models/request/ValidateSchemaRequest.java @@ -8,6 +8,7 @@ import lombok.Data; import lombok.NoArgsConstructor; +import javax.validation.Valid; import javax.validation.constraints.NotNull; @Data @@ -16,6 +17,7 @@ @NoArgsConstructor @JsonIgnoreProperties(ignoreUnknown = true) public class ValidateSchemaRequest { + @Valid @NotNull private SchemaKey schemaKey; @NotNull diff --git a/leia-models/src/main/java/com/grookage/leia/models/schema/SchemaDetails.java b/leia-models/src/main/java/com/grookage/leia/models/schema/SchemaDetails.java index 47390f4..7306090 100644 --- a/leia-models/src/main/java/com/grookage/leia/models/schema/SchemaDetails.java +++ b/leia-models/src/main/java/com/grookage/leia/models/schema/SchemaDetails.java @@ -66,7 +66,7 @@ public boolean match(final SchemaKey thatKey) { @JsonIgnore public String getReferenceId() { - return Joiner.on(".").join(namespace, schemaName, version).toUpperCase(Locale.ROOT); + return Joiner.on(":").join(namespace, schemaName, version).toUpperCase(Locale.ROOT); } @JsonIgnore diff --git a/leia-models/src/main/java/com/grookage/leia/models/schema/SchemaKey.java b/leia-models/src/main/java/com/grookage/leia/models/schema/SchemaKey.java index 424cc42..ad76c57 100644 --- a/leia-models/src/main/java/com/grookage/leia/models/schema/SchemaKey.java +++ b/leia-models/src/main/java/com/grookage/leia/models/schema/SchemaKey.java @@ -24,6 +24,7 @@ import lombok.Data; import lombok.NoArgsConstructor; +import javax.validation.constraints.NotBlank; import java.util.Locale; @Builder @@ -32,13 +33,16 @@ @NoArgsConstructor @JsonIgnoreProperties(ignoreUnknown = true) public class SchemaKey { + @NotBlank private String namespace; + @NotBlank private String schemaName; + @NotBlank private String version; @JsonIgnore public String getReferenceId() { - return Joiner.on(".").join(namespace, schemaName, version).toUpperCase(Locale.ROOT); + return Joiner.on(":").join(namespace, schemaName, version).toUpperCase(Locale.ROOT); } @Override