Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grml-chroot: remove useless message #9

Open
akorn opened this issue Mar 5, 2020 · 3 comments
Open

grml-chroot: remove useless message #9

akorn opened this issue Mar 5, 2020 · 3 comments

Comments

@akorn
Copy link

akorn commented Mar 5, 2020

    echo "Writing /etc/debian_chroot ..."

I think this line in grml-chroot is unnecessary and annoying; it can clutter up the display when grml-chroot is called several times by a script.

Maybe have a $GRML_CHROOT_VERBOSE setting or something for people who really want/need to see this message? If you think it should definitely be shown by default, please provide a way to turn it off.

@mika
Copy link
Member

mika commented Jun 23, 2020

I'm still unsure how to handle this one, I think it's good to be aware that /etc/debian_chroot is automatically created by grml-chroot (and later on removed), though I agree that this might be annoying if it gets invoked multiple times in a script (as reported by @akorn).

I personally am not a big fan of adding environment variables, especially as this just might not be taken care of/noticed/used at all, so I'd prefer it to have sane defaults and the default should make sense for the majority of users. So should it be quiet by default or verbose by default? :)

Opinions, ideas? @jkirk @zeha @formorer

@jkirk
Copy link
Contributor

jkirk commented Jun 24, 2020

I'm still unsure how to handle this one, I think it's good to be aware that /etc/debian_chroot is automatically created by grml-chroot (and later on removed), though I agree that this might be annoying if it gets invoked multiple times in a script (as reported by @akorn).

I am unsure about this one. Setting /etc/debian_chroot is useful and important but I am not sure about the echo line. My feeling is that this is more of a verbose output and could be dropped. I will have a close look the next time I use the grml-chroot (interactively and via scripts).

@akorn
Copy link
Author

akorn commented Jun 24, 2020

How about you show it only once for every chroot? I don't know, maybe touch /run/grml-chroot.message.shown.${chroot_path//\/_} to remember it, or something similar?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants