Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing candidates to be based on binding OR percentile cutoff. #1142

Open
malachig opened this issue Sep 9, 2024 · 2 comments
Open

Comments

@malachig
Copy link
Member

malachig commented Sep 9, 2024

Based the current docs it sounds a candidate it filtered out unless it passes both of these cutoffs.

  -b BINDING_THRESHOLD, --binding-threshold BINDING_THRESHOLD
                        Report only epitopes where the mutant allele has ic50
                        binding scores below this value. (default: 500)
  --percentile-threshold PERCENTILE_THRESHOLD
                        Report only epitopes where the mutant allele has a
                        percentile rank below this value. (default: None)

Is that a correct interpretation for what would happen if you set a value for both of these?

It would be nice if this could be interpreted as an either OR parameter. So that for example, if a candidate is <500 nm OR <1% it would be considered a pass.

@susannasiebert
Copy link
Contributor

Yes, that is correct. Is that a general change to the behavior we want to make or something that should be configurable?

@malachig
Copy link
Member Author

malachig commented Sep 9, 2024

It just keeps adding more complexity, but I guess it could be nice to have this configurable based on intent:

  • One wishes to be conservative, so one requires BOTH criteria to be met to get a pass
  • One wishes to get more candidates, so one required EITHER criteria to be met to get a pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants