From 8087dda47a57530ece29b79febfe8ba2c88860e3 Mon Sep 17 00:00:00 2001 From: Andreas Coroiu Date: Mon, 30 Oct 2023 13:40:58 +0100 Subject: [PATCH] [PM-2023] chore: clean up assertion endpoint --- .../WebAuthnLoginAssertionOptionsRequestModel.cs | 10 ---------- src/Identity/Controllers/AccountsController.cs | 4 +--- 2 files changed, 1 insertion(+), 13 deletions(-) delete mode 100644 src/Core/Auth/Models/Api/Request/Accounts/WebAuthnLoginAssertionOptionsRequestModel.cs diff --git a/src/Core/Auth/Models/Api/Request/Accounts/WebAuthnLoginAssertionOptionsRequestModel.cs b/src/Core/Auth/Models/Api/Request/Accounts/WebAuthnLoginAssertionOptionsRequestModel.cs deleted file mode 100644 index 4d4ce9c0f1dc..000000000000 --- a/src/Core/Auth/Models/Api/Request/Accounts/WebAuthnLoginAssertionOptionsRequestModel.cs +++ /dev/null @@ -1,10 +0,0 @@ -namespace Bit.Core.Auth.Models.Api.Request.Accounts; - -public class WebAuthnLoginAssertionOptionsRequestModel -{ - // Requried to add support for non-discoverable logins - // [EmailAddress] - // [StringLength(256)] - // public string Email { get; set; } -} - diff --git a/src/Identity/Controllers/AccountsController.cs b/src/Identity/Controllers/AccountsController.cs index bf2f3fec511d..a04e7478a60c 100644 --- a/src/Identity/Controllers/AccountsController.cs +++ b/src/Identity/Controllers/AccountsController.cs @@ -82,10 +82,8 @@ public async Task PostPrelogin([FromBody] PreloginRequest } [HttpPost("webauthn/assertion-options")] - [ApiExplorerSettings(IgnoreApi = true)] // Disable Swagger due to CredentialCreateOptions not converting properly [RequireFeature(FeatureFlagKeys.PasswordlessLogin)] - // TODO: Add tests - public async Task PostWebAuthnLoginAssertionOptions(WebAuthnLoginAssertionOptionsRequestModel model) + public async Task PostWebAuthnLoginAssertionOptions() { var options = await _userService.StartWebAuthnLoginAssertionAsync();