Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OpenGL object leaks #79

Open
kroppt opened this issue Jan 12, 2021 · 1 comment
Open

Fix OpenGL object leaks #79

kroppt opened this issue Jan 12, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@kroppt
Copy link
Collaborator

kroppt commented Jan 12, 2021

No description provided.

@kroppt kroppt added the bug Something isn't working label Jan 12, 2021
@kroppt
Copy link
Collaborator Author

kroppt commented Jan 12, 2021

I created a GL trace of the application, just opening and closing.
I ran $ apitrace leaks tabula-editor.trace and got:

3541: error: texture 1 was not destroyed until <EOF>
3553: error: texture 2 was not destroyed until <EOF>
3719: error: texture 3 was not destroyed until <EOF>
3765: error: texture 4 was not destroyed until <EOF>
3560: error: buffer 1 was not destroyed until <EOF>
3564: error: buffer 2 was not destroyed until <EOF>
3568: error: buffer 3 was not destroyed until <EOF>
3570: error: buffer 4 was not destroyed until <EOF>
3582: error: buffer 5 was not destroyed until <EOF>
<snip>

It goes on a while. While I am not sure apitrace is accurate, looking at the code, it does appear we are missing destructors in some places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant