Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

play-pause-btn aria-label="Play" issue #30

Open
amir2mi opened this issue May 2, 2020 · 0 comments
Open

play-pause-btn aria-label="Play" issue #30

amir2mi opened this issue May 2, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@amir2mi
Copy link

amir2mi commented May 2, 2020

Hi, thank you for developing this fantastic audio player.

when I set {stopOthersOnPlay: true } and clicked to play multiple players I found this "aria-label" does not change the value to "Pause".

suggestion: and it is better to add class "is-playing" and something like this when the player starts playing.
@greghub greghub added the bug Something isn't working label Jun 3, 2020
This was referenced Aug 21, 2021
Closed
Closed
tnbnicer added a commit to tnbnicer/green-audio-player that referenced this issue Aug 21, 2021
@tnbnicer
Bug Issue greghub#30 patch
ac36450 
Patch for play-pause-btn aria-label="Play" issue greghub#30
@tnbnicer tnbnicer mentioned this issue Aug 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@greghub @amir2mi