PLANET-6825: Page creation UI integration #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GP-Dan-Tovbein
force-pushed
the
PLANET-6825_page_creation_ui
branch
from
7c6d630 to
ea8f6d7
Compare
planet-4
added a commit
to greenpeace/planet4-test-sinope
that referenced
this pull request
Jun 29, 2022
/unhold e9dfd7aa-d285-4e9a-8919-4db47e2fdc37
Test instance is ready 🚀🌑 pandora | admin | blocks report | CircleCI | composer-local.json ⌚ 2022.07.01 14:16:29 |
GP-Dan-Tovbein
force-pushed
the
PLANET-6825_page_creation_ui
branch
from
ea8f6d7 to
67e399f
Compare
planet-4
added a commit
to greenpeace/planet4-test-sinope
that referenced
this pull request
Jun 29, 2022
/unhold 04ae2e20-7c3b-4976-be7f-7941d555d7de
GP-Dan-Tovbein
force-pushed
the
PLANET-6825_page_creation_ui
branch
from
67e399f to
c67a001
Compare
planet-4
added a commit
to greenpeace/planet4-test-sinope
that referenced
this pull request
Jun 29, 2022
/unhold c5cd9c8c-1079-4bd2-a95b-55b60237fae4
GP-Dan-Tovbein
force-pushed
the
PLANET-6825_page_creation_ui
branch
from
c67a001 to
1186e53
Compare
planet-4
added a commit
to greenpeace/planet4-test-sinope
that referenced
this pull request
Jun 29, 2022
/unhold 759774bd-9180-4f47-a9fe-69f5cf352ba9
GP-Dan-Tovbein
commented
Jun 29, 2022
| public static function get_config( $params = [] ): array { | ||
| return [ | ||
| 'title' => __( 'Blank page', 'planet4-blocks-backend' ), | ||
| 'blockTypes' => [ 'core/post-content' ], |
There was a problem hiding this comment.
We need to add this config for adding it into the page creation popup.
GP-Dan-Tovbein
changed the title
comzeradd
reviewed
Jul 1, 2022
- Create a "new blank" page as a pattern
GP-Dan-Tovbein
force-pushed
the
PLANET-6825_page_creation_ui
branch
from
1186e53 to
a1b855a
Compare
planet-4
added a commit
to greenpeace/planet4-test-pandora
that referenced
this pull request
Jul 1, 2022
/unhold cd123ef7-d930-46b3-8e5b-48ba3103487c
planet-4
added a commit
to greenpeace/planet4-test-pandora
that referenced
this pull request
Jul 1, 2022
/unhold 0e20abde-e8af-47d2-ab8d-29c8fe9d320b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://jira.greenpeace.org/browse/PLANET-6825
Create a new "blank page" pattern as a starting point.
Testing Instructions
Go to the sinope's instance and create a new page. Then, you'll be able to pick the desired pattern (for now only a the Blank page) when the page is empty.
More info about this feature