Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EC7] [Java] [Python] Getter/Setters not to do by overload + update Python ressource file #123

Closed
Houssainatou opened this issue Apr 5, 2023 · 6 comments · Fixed by #262
Assignees
Labels
🗃️ rule rule improvment or rule development or bug 🏆 challenge2023 🏆 Work done during the ecoCode Challenge 2023 java __PRIO_MEDIUM__ python

Comments

@Houssainatou
Copy link

Equipe 5R

@dedece35 dedece35 added 🗃️ rule rule improvment or rule development or bug java 🏆 challenge2023 🏆 Work done during the ecoCode Challenge 2023 labels Apr 5, 2023
@Houssainatou Houssainatou changed the title EC7 - Java Getter/Setters not to do by override EC7 - Java Getter/Setters not to do by overload Apr 5, 2023
@Houssainatou
Copy link
Author

Cette règle n'est pas valable en java car supprimer les getters/setters impliquerait de changer la visibilité des attributs, ce qui ne respecte pas le principe.

@Silicoman
Copy link
Contributor

@Houssainatou , tu peux rename le titre avec le titre + python pour que personne reimplemente les corrections ?

@Silicoman
Copy link
Contributor

PR #134

@Houssainatou Houssainatou changed the title EC7 - Java Getter/Setters not to do by overload EC7 - Java Getter/Setters not to do by overload + update Python ressource file Apr 6, 2023
@dedece35 dedece35 changed the title EC7 - Java Getter/Setters not to do by overload + update Python ressource file [EC7] [Java] [Python] Getter/Setters not to do by overload + update Python ressource file Aug 25, 2023
@dedece35
Copy link
Member

dedece35 commented Dec 11, 2023

la remarque est aussi valable en PHP : si attribut privé alors si présence d'un getter et/ou un setter il NE faut PAS remonter d'alertes (car c'est une bonne pratique = validé avec un archi PHP de chez PagesJaunes)

autre idée à implémenter : si un attribut est public (ça peut arriver en PHP par exemple dans certains cas) et qu'il existe un getter et/ou un setter alors remonter une alerte car ne servent à rien

@dedece35 dedece35 assigned dedece35 and unassigned Houssainatou Dec 11, 2023
@dedece35 dedece35 linked a pull request Dec 15, 2023 that will close this issue
@dedece35
Copy link
Member

dedece35 commented Dec 15, 2023

@jhertout @utarwyn @glalloue
on est ok du coup qu'on marque la règle EC7 comme non applicable en Java ni en PHP ?
Cette règle n'est pour le moment seulement implémentée en Python et est ok.

@dedece35
Copy link
Member

dedece35 commented Jan 1, 2024

issue closed because modifications done on differents repositories (now, we have one repository by language for ecocode).
all is ok.
thank you a lot @Silicoman @Houssainatou

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🗃️ rule rule improvment or rule development or bug 🏆 challenge2023 🏆 Work done during the ecoCode Challenge 2023 java __PRIO_MEDIUM__ python
Projects
None yet
3 participants