From 9ea9efa6b8150a651fb00d174c74ae7aa0581a47 Mon Sep 17 00:00:00 2001
From: utarwyn <maxime.malgorn@laposte.net>
Date: Mon, 18 Sep 2023 20:52:23 +0200
Subject: [PATCH] Move all Javascript rules

---
 .../src/main/rules/EC11/EC11.json             |  4 +-
 .../main/rules/EC11/javascript/EC11.asciidoc  | 17 +++++----
 .../src/main/rules/EC12/EC12.json             |  4 +-
 .../main/rules/EC12/javascript/EC12.asciidoc  | 14 +++----
 .../src/main/rules/EC13/EC13.json             |  6 +--
 .../main/rules/EC13/javascript/EC13.asciidoc  | 14 +++----
 .../EC24/{js => javascript}/EC24.asciidoc     |  0
 .../EC25/{js => javascript}/EC25.asciidoc     |  0
 .../EC26/{js => javascript}/EC26.asciidoc     |  0
 .../EC29/{js => javascript}/EC29.asciidoc     |  0
 .../EC30/{js => javascript}/EC30.asciidoc     |  0
 .../src/main/rules/EC8/EC8.json               |  4 +-
 .../main/rules/EC8/javascript/EC8.asciidoc    | 19 +++++-----
 .../src/main/rules/EC9/EC9.json               |  4 +-
 .../main/rules/EC9/javascript/EC9.asciidoc    | 38 +++++--------------
 15 files changed, 54 insertions(+), 70 deletions(-)
 rename ecocode-rules-specifications/src/main/rules/EC24/{js => javascript}/EC24.asciidoc (100%)
 rename ecocode-rules-specifications/src/main/rules/EC25/{js => javascript}/EC25.asciidoc (100%)
 rename ecocode-rules-specifications/src/main/rules/EC26/{js => javascript}/EC26.asciidoc (100%)
 rename ecocode-rules-specifications/src/main/rules/EC29/{js => javascript}/EC29.asciidoc (100%)
 rename ecocode-rules-specifications/src/main/rules/EC30/{js => javascript}/EC30.asciidoc (100%)

diff --git a/ecocode-rules-specifications/src/main/rules/EC11/EC11.json b/ecocode-rules-specifications/src/main/rules/EC11/EC11.json
index 878a34665..1e878d469 100644
--- a/ecocode-rules-specifications/src/main/rules/EC11/EC11.json
+++ b/ecocode-rules-specifications/src/main/rules/EC11/EC11.json
@@ -7,9 +7,9 @@
     "constantCost": "5min"
   },
   "tags": [
+    "ecocode",
     "eco-design",
-    "performance",
-    "ecocode"
+    "performance"
   ],
   "defaultSeverity": "Major",
   "compatibleLanguages": [
diff --git a/ecocode-rules-specifications/src/main/rules/EC11/javascript/EC11.asciidoc b/ecocode-rules-specifications/src/main/rules/EC11/javascript/EC11.asciidoc
index b5a2a8649..a932fa16c 100644
--- a/ecocode-rules-specifications/src/main/rules/EC11/javascript/EC11.asciidoc
+++ b/ecocode-rules-specifications/src/main/rules/EC11/javascript/EC11.asciidoc
@@ -1,20 +1,21 @@
-## Rule details
+This rule aims to reduce DOM access assigning its object to variable when access multiple time.
+It saves CPU cycles.
 
-This rule aims to reduce DOM access assigning its object to variable when access multiple time. It saves CPU cycles.
-
-## Examples
+== Examples
 
 Examples of **incorrect** code for this rule:
 
-```js
+[source,js]
+----
 var el1 = document.getElementById("block1").test1;
 var el2 = document.getElementById("block1").test2;
-```
+----
 
 Examples of **correct** code for this rule:
 
-```js
+[source,js]
+----
 var blockElement = document.getElementById("block1");
 var el1 = blockElement.test1;
 var el2 = blockElement.test2;
-```
+----
diff --git a/ecocode-rules-specifications/src/main/rules/EC12/EC12.json b/ecocode-rules-specifications/src/main/rules/EC12/EC12.json
index 67c6010cf..06c452765 100644
--- a/ecocode-rules-specifications/src/main/rules/EC12/EC12.json
+++ b/ecocode-rules-specifications/src/main/rules/EC12/EC12.json
@@ -7,9 +7,9 @@
     "constantCost": "10min"
   },
   "tags": [
+    "ecocode",
     "eco-design",
-    "performance",
-    "ecocode"
+    "performance"
   ],
   "defaultSeverity": "Major",
   "compatibleLanguages": [
diff --git a/ecocode-rules-specifications/src/main/rules/EC12/javascript/EC12.asciidoc b/ecocode-rules-specifications/src/main/rules/EC12/javascript/EC12.asciidoc
index 5bd836997..7793d7389 100644
--- a/ecocode-rules-specifications/src/main/rules/EC12/javascript/EC12.asciidoc
+++ b/ecocode-rules-specifications/src/main/rules/EC12/javascript/EC12.asciidoc
@@ -1,24 +1,24 @@
-## Rule Details
-
 This rule aims to disallow batching multiple style changes at once.
 
 To limit the number of repaint/reflow, it is advised to batch style modifications by adding a class containing all style changes that will generate a unique reflow.
 
-## Examples
+== Examples
 
 Examples of **non-compliant** code for this rule:
 
-```html
+[source,html]
+----
 <script>
   element.style.height = "800px";
   element.style.width = "600px";
   element.style.color = "red";
 </script>
-```
+----
 
 Examples of **compliant** code for this rule:
 
-```html
+[source,html]
+----
 <style>
   .in-error {
     color: red;
@@ -30,4 +30,4 @@ Examples of **compliant** code for this rule:
 <script>
   element.addClass("in-error");
 </script>
-```
+----
diff --git a/ecocode-rules-specifications/src/main/rules/EC13/EC13.json b/ecocode-rules-specifications/src/main/rules/EC13/EC13.json
index 6ff60b4fa..4a12071f3 100644
--- a/ecocode-rules-specifications/src/main/rules/EC13/EC13.json
+++ b/ecocode-rules-specifications/src/main/rules/EC13/EC13.json
@@ -7,13 +7,13 @@
     "constantCost": "30min"
   },
   "tags": [
+    "ecocode",
     "eco-design",
-    "performance",
-    "ecocode"
+    "nestjs",
+    "performance"
   ],
   "defaultSeverity": "Minor",
   "compatibleLanguages": [
-    "JAVASCRIPT",
     "TYPESCRIPT"
   ]
 }
diff --git a/ecocode-rules-specifications/src/main/rules/EC13/javascript/EC13.asciidoc b/ecocode-rules-specifications/src/main/rules/EC13/javascript/EC13.asciidoc
index abc58bf6c..97fd656f2 100644
--- a/ecocode-rules-specifications/src/main/rules/EC13/javascript/EC13.asciidoc
+++ b/ecocode-rules-specifications/src/main/rules/EC13/javascript/EC13.asciidoc
@@ -1,22 +1,22 @@
-## Rule details
-
 This rule aims to reduce the size and thus the network weight of API returns that may contain many elements. This rule is built for the https://nestjs.com[NestJS framework] but can work with a controller `@Controller()` and a decorated method `@Get()`.
 
-## Examples
+== Examples
 
 Examples of **non-compliant** code for this rule:
 
-```typescript
+[source,typescript]
+----
 @Controller()
 class Test {
   @Get()
   public find(): Promise<string[]> {}
 }
-```
+----
 
 Examples of **compliant** code for this rule:
 
-```typescript
+[source,typescript]
+----
 interface Pagination {
   items: string[];
   currentPage: number;
@@ -28,4 +28,4 @@ class Test {
   @Get()
   public find(): Promise<Pagination> {}
 }
-```
+----
diff --git a/ecocode-rules-specifications/src/main/rules/EC24/js/EC24.asciidoc b/ecocode-rules-specifications/src/main/rules/EC24/javascript/EC24.asciidoc
similarity index 100%
rename from ecocode-rules-specifications/src/main/rules/EC24/js/EC24.asciidoc
rename to ecocode-rules-specifications/src/main/rules/EC24/javascript/EC24.asciidoc
diff --git a/ecocode-rules-specifications/src/main/rules/EC25/js/EC25.asciidoc b/ecocode-rules-specifications/src/main/rules/EC25/javascript/EC25.asciidoc
similarity index 100%
rename from ecocode-rules-specifications/src/main/rules/EC25/js/EC25.asciidoc
rename to ecocode-rules-specifications/src/main/rules/EC25/javascript/EC25.asciidoc
diff --git a/ecocode-rules-specifications/src/main/rules/EC26/js/EC26.asciidoc b/ecocode-rules-specifications/src/main/rules/EC26/javascript/EC26.asciidoc
similarity index 100%
rename from ecocode-rules-specifications/src/main/rules/EC26/js/EC26.asciidoc
rename to ecocode-rules-specifications/src/main/rules/EC26/javascript/EC26.asciidoc
diff --git a/ecocode-rules-specifications/src/main/rules/EC29/js/EC29.asciidoc b/ecocode-rules-specifications/src/main/rules/EC29/javascript/EC29.asciidoc
similarity index 100%
rename from ecocode-rules-specifications/src/main/rules/EC29/js/EC29.asciidoc
rename to ecocode-rules-specifications/src/main/rules/EC29/javascript/EC29.asciidoc
diff --git a/ecocode-rules-specifications/src/main/rules/EC30/js/EC30.asciidoc b/ecocode-rules-specifications/src/main/rules/EC30/javascript/EC30.asciidoc
similarity index 100%
rename from ecocode-rules-specifications/src/main/rules/EC30/js/EC30.asciidoc
rename to ecocode-rules-specifications/src/main/rules/EC30/javascript/EC30.asciidoc
diff --git a/ecocode-rules-specifications/src/main/rules/EC8/EC8.json b/ecocode-rules-specifications/src/main/rules/EC8/EC8.json
index 232f1ce0a..63ce5394e 100644
--- a/ecocode-rules-specifications/src/main/rules/EC8/EC8.json
+++ b/ecocode-rules-specifications/src/main/rules/EC8/EC8.json
@@ -7,9 +7,9 @@
     "constantCost": "5min"
   },
   "tags": [
+    "ecocode",
     "eco-design",
-    "performance",
-    "ecocode"
+    "performance"
   ],
   "defaultSeverity": "Major",
   "compatibleLanguages": [
diff --git a/ecocode-rules-specifications/src/main/rules/EC8/javascript/EC8.asciidoc b/ecocode-rules-specifications/src/main/rules/EC8/javascript/EC8.asciidoc
index 7528b2bb2..10f331852 100644
--- a/ecocode-rules-specifications/src/main/rules/EC8/javascript/EC8.asciidoc
+++ b/ecocode-rules-specifications/src/main/rules/EC8/javascript/EC8.asciidoc
@@ -1,12 +1,11 @@
-## Rule details
-
 This rule aims at reducing CPU consumption by telling the device to use a less accurate yet more eco-friendly geolocation, when geolocation API is used.
 
-## Examples
+== Examples
 
 Examples of **non-compliant** code for this rule:
 
-```js
+[source,js]
+----
 var options = { enableHighAccuracy: true, timeout: 5000, maximumAge: 0 };
 function success(pos) {
   console.log(pos.coords);
@@ -17,19 +16,21 @@ function error(err) {
 }
 
 navigator.geolocation.getCurrentPosition(success, error, options);
-```
+----
 
 Examples of **compliant** code for this rule:
 
-```js
+[source,js]
+----
 // enableHighAccuracy is false by default, so not declaring it is correct
 function success(pos) {
   console.log(pos);
 }
 navigator.geolocation.getCurrentPosition(success);
-```
+----
 
-```js
+[source,js]
+----
 var options = { enableHighAccuracy: false, timeout: 5000, maximumAge: 0 };
 function success(pos) {
   console.log(pos.coords);
@@ -40,4 +41,4 @@ function error(err) {
 }
 
 navigator.geolocation.getCurrentPosition(success, error, options);
-```
+----
diff --git a/ecocode-rules-specifications/src/main/rules/EC9/EC9.json b/ecocode-rules-specifications/src/main/rules/EC9/EC9.json
index 99e524b50..78ca94bdf 100644
--- a/ecocode-rules-specifications/src/main/rules/EC9/EC9.json
+++ b/ecocode-rules-specifications/src/main/rules/EC9/EC9.json
@@ -7,9 +7,9 @@
     "constantCost": "15min"
   },
   "tags": [
+    "ecocode",
     "eco-design",
-    "performance",
-    "ecocode"
+    "performance"
   ],
   "defaultSeverity": "Major",
   "compatibleLanguages": [
diff --git a/ecocode-rules-specifications/src/main/rules/EC9/javascript/EC9.asciidoc b/ecocode-rules-specifications/src/main/rules/EC9/javascript/EC9.asciidoc
index c6be22d50..cd0e2ec2a 100644
--- a/ecocode-rules-specifications/src/main/rules/EC9/javascript/EC9.asciidoc
+++ b/ecocode-rules-specifications/src/main/rules/EC9/javascript/EC9.asciidoc
@@ -1,11 +1,10 @@
-## Rule details
-
-This rule aims to reduce weight of programs by using only needed modules. Many libraries export only one module by default, but some of them are exporting ES modules or submodules. We should use them to select more precisly needed modules and avoid unnecessarily overloading files weight.
+This rule aims to reduce weight of programs by using only needed modules.
+Many libraries export only one module by default, but some of them are exporting ES modules or submodules.
+We should use them to select more precisly needed modules and avoid unnecessarily overloading files weight.
 
 *Example with the well-known https://lodash.com/[lodash] library, if you only need
 `isEmpty` method.*
 
-
 |===
 |Full lodash library |Only `isEmpty` method
 
@@ -24,30 +23,12 @@ a|index.js - 24.42 KB
 
 |===
 
-## Options
-
-You can externally add your own libraries to be checked. To add your own libraries you need to modify your .eslintrc.js by adding the following rule configuration:
-
-```js
-module.exports = {
-  ...yourConf,
-  rules: {
-    "no-import-all-from-library": [
-      "warn",
-      {
-        notAllowedLibraries: ["some-lib"], // will check for -> import someLib from "some-lib"
-        importByNamespaceNotAllowedLibraries: ["some-other-lib"], // will check for -> import * as someOtherLib from "some-other-lib"
-      },
-    ],
-  },
-};
-```
-
-## Examples
+== Examples
 
 Examples of **non-compliant** code for this rule:
 
-```js
+[source,js]
+----
 // Example with lodash
 import lodash from "lodash";
 import { isEmpty } from "lodash";
@@ -55,15 +36,16 @@ import * as lodash from "lodash";
 
 // Example with underscore
 import _ from "underscore";
-```
+----
 
 Examples of **compliant** code for this rule:
 
-```js
+[source,js]
+----
 // Example with lodash (uses submodules)
 import isEmpty from "lodash/isEmpty";
 import intersect from "lodash/intersect";
 
 // Example with underscore (uses esm modules)
 import map from "underscore/modules/map.js";
-```
+----