Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep mode does not capture contiguous samples at each tuning step when num_bytes > 16KB #1506

Open
martinling opened this issue Nov 22, 2024 · 0 comments
Labels
enhancement potential new feature

Comments

@martinling
Copy link
Member

What feature would you like to see and why?

When sweep mode is set up with dwell_blocks greater than one, i.e. num_bytes more than 16KB, the firmware captures that many blocks - but not contiguously. It also adds a header to every 16KB block.

This is not that useful, because e.g. an FFT over all the samples captured at each tuning step will not give valid results.

A more useful behaviour would be to capture the number of bytes requested as contiguous samples, and then apply a single header only at the start of that data.

However, since this would differ from previous behaviour (which has always added a per-16KB-block header), we'll need to come up with a way to explicitly request this. A new value of sweep_style might be the way to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement potential new feature
Projects
None yet
Development

No branches or pull requests

1 participant