-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve handling aria-*
props across all components
#1929
Comments
can i take this? |
@blasdfaa are you still interested in taking on this task? It's quite specific, so perhaps you'd prefer to choose something else? |
Moving a discussion from Telegram to this issue per @korvin89's instruction. Context: I asked for help finding a universal approach for passing arbitrary HTML attributes to any component. I wanted such an approach for my local components but wanted to keep it in sync with Gravity's approach. The specific case was for testing purposes but the discussion grew to the general problem of passing attributes. @korvin89 told me that it was not appropriate to discus the matter in a Telegram group dedicated to testing matters and gave me a link to this issue. @korvin89, this issue's reference implementation only supports four ARIA attributes: There are over 50 ARIA attributes that might be arbitrarily required on root elements of any component. So am I supposed to create a feature request for every individual attribute whenever I need it? And you say I must provide justification for usage of each individual attribute? And you already denied my suggestion to add support for passing Is this the official position of Gravity maintainers? If I have a case where I need to, say, add Same question for non-ARIA attributes such as TL/DR: I wish I was able to pass any universal HTML attribute to the root element of any component, without soul-crushing bureaucracy that slows down feature development cycle from hours to weeks. Is it such a crazy thing to ask? |
@lolmaus this issue is not relevant to your feature request. I've shown them just for your information. |
In almost every component we use the same set of two props for labeling:
aria-label
,aria-labelledby
and duplicate code every time. We can now support more props and remove duplication using new interface and helper.Look at PinInput as a reference
The text was updated successfully, but these errors were encountered: