Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NET-591): allow generic DNS entries #2568

Merged
merged 2 commits into from
Sep 20, 2023
Merged

feat(NET-591): allow generic DNS entries #2568

merged 2 commits into from
Sep 20, 2023

Conversation

pwilson77
Copy link
Contributor

Describe your changes

Allow users to create generic DNS entries that are not tied to the network TLD. E.g. "myserver.example.com"

Provide Issue ticket number if applicable/not in title

NET-591

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

@CLAassistant
Copy link

CLAassistant commented Sep 11, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@abhishek9686
Copy link
Member

@pwilson77 fix unit tests, they are failing

Aceix
Aceix requested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@Aceix Aceix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix tests

@pwilson77
Copy link
Contributor Author

fix tests

Fixed the test failures

@pwilson77 pwilson77 closed this Sep 12, 2023
@pwilson77 pwilson77 reopened this Sep 12, 2023
@abhishek9686 abhishek9686 merged commit fe842e0 into develop Sep 20, 2023
7 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattkasun mattkasun mattkasun approved these changes

@abhishek9686 abhishek9686 abhishek9686 approved these changes

@Aceix Aceix Aceix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pwilson77 @CLAassistant @abhishek9686 @Aceix @mattkasun