fix: remove blink effect when refresh skeleton attribute

fix #309
gravitee-io · Mar 23, 2021 · edcaf1b · edcaf1b
1 parent 7ccef4b
commit edcaf1b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/mixins/with-skeleton-attribute.js b/src/mixins/with-skeleton-attribute.js
@@ -54,16 +54,22 @@ export function withSkeletonAttribute(ParentClass) {
 
     constructor() {
       super();
+      this._reset();
+    }
+
+    _reset() {
       this._invisible = true;
+      if (this._skeletonAttribute != null && this[`_${this._skeletonAttribute}`] != null) {
+        delete this[`_${this._skeletonAttribute}`];
+      }
       this._skeleton = false;
       this._error = false;
       this._empty = false;
     }
 
     updated(changedProperties) {
       if (this._skeletonAttribute != null && changedProperties.has(this._skeletonAttribute)) {
-        this._error = false;
-        this._empty = false;
+        this._reset();
         const start = new Date().getTime();
         let end = null;
         const timer = setTimeout(() => {

diff --git a/stories/charts/gv-chart-pie.stories.js b/stories/charts/gv-chart-pie.stories.js
@@ -79,6 +79,15 @@ export const Loading = makeStory(conf, {
     storyWait(750, () => {
       seriesResolver(series);
     }),
+
+    storyWait(1500, ([component]) => {
+      component.series = new Promise((resolve) => (seriesResolver = resolve));
+      component.options = options;
+    }),
+
+    storyWait(2250, () => {
+      seriesResolver(series);
+    }),
   ],
 });