From b6e82ddc9c04c08b7a1d6178a07be1bae4946a3b Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Wed, 19 Jun 2024 16:21:53 +0200 Subject: [PATCH 1/6] Update GraphiQL from 3.2.3 to 3.3.1 version (#1264) Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kai Ren --- juniper/CHANGELOG.md | 4 ++-- juniper/package.json | 2 +- juniper/src/http/graphiql.html | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/juniper/CHANGELOG.md b/juniper/CHANGELOG.md index b488874e0..1f10af617 100644 --- a/juniper/CHANGELOG.md +++ b/juniper/CHANGELOG.md @@ -17,10 +17,10 @@ All user visible changes to `juniper` crate will be documented in this file. Thi ### Changed -- Updated [GraphiQL] to [3.2.3 version](https://github.com/graphql/graphiql/blob/graphiql%403.2.2/packages/graphiql/CHANGELOG.md#322). ([#1260]) +- Updated [GraphiQL] to [3.3.1 version](https://github.com/graphql/graphiql/blob/graphiql%403.3.1/packages/graphiql/CHANGELOG.md#331). ([#1264]) [#1252]: /../../pull/1252 -[#1260]: /../../pull/1260 +[#1264]: /../../pull/1264 diff --git a/juniper/package.json b/juniper/package.json index 87da5f1f9..aeb6fdb40 100644 --- a/juniper/package.json +++ b/juniper/package.json @@ -4,7 +4,7 @@ "postinstall": "make graphiql graphql-playground" }, "dependencies": { - "graphiql": "3.2.3", + "graphiql": "3.3.1", "graphql-playground-react": "1.7.28" } } diff --git a/juniper/src/http/graphiql.html b/juniper/src/http/graphiql.html index d8bd30869..5cc2fd2d7 100644 --- a/juniper/src/http/graphiql.html +++ b/juniper/src/http/graphiql.html @@ -42,10 +42,10 @@ favored resource bundler. --> - + From a4974e179bb0f3350a23a0ceff76395a4fc034b4 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 4 Jul 2024 13:49:28 +0200 Subject: [PATCH 2/6] Update GraphiQL from 3.3.1 to 3.3.2 version (#1265) Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kai Ren --- juniper/CHANGELOG.md | 4 ++-- juniper/package.json | 2 +- juniper/src/http/graphiql.html | 4 ++-- .../codegen/fail/union/struct_same_type_ugly.stderr | 12 ++++++------ 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/juniper/CHANGELOG.md b/juniper/CHANGELOG.md index 1f10af617..21e0c3bd5 100644 --- a/juniper/CHANGELOG.md +++ b/juniper/CHANGELOG.md @@ -17,10 +17,10 @@ All user visible changes to `juniper` crate will be documented in this file. Thi ### Changed -- Updated [GraphiQL] to [3.3.1 version](https://github.com/graphql/graphiql/blob/graphiql%403.3.1/packages/graphiql/CHANGELOG.md#331). ([#1264]) +- Updated [GraphiQL] to [3.3.2 version](https://github.com/graphql/graphiql/blob/graphiql%403.3.2/packages/graphiql/CHANGELOG.md#332). ([#1265]) [#1252]: /../../pull/1252 -[#1264]: /../../pull/1264 +[#1265]: /../../pull/1265 diff --git a/juniper/package.json b/juniper/package.json index aeb6fdb40..6196fb403 100644 --- a/juniper/package.json +++ b/juniper/package.json @@ -4,7 +4,7 @@ "postinstall": "make graphiql graphql-playground" }, "dependencies": { - "graphiql": "3.3.1", + "graphiql": "3.3.2", "graphql-playground-react": "1.7.28" } } diff --git a/juniper/src/http/graphiql.html b/juniper/src/http/graphiql.html index 5cc2fd2d7..20bce4d2b 100644 --- a/juniper/src/http/graphiql.html +++ b/juniper/src/http/graphiql.html @@ -42,10 +42,10 @@ favored resource bundler. --> - + diff --git a/tests/codegen/fail/union/struct_same_type_ugly.stderr b/tests/codegen/fail/union/struct_same_type_ugly.stderr index 8e0ca39a2..bc6c8e81f 100644 --- a/tests/codegen/fail/union/struct_same_type_ugly.stderr +++ b/tests/codegen/fail/union/struct_same_type_ugly.stderr @@ -10,10 +10,10 @@ error[E0119]: conflicting implementations of trait `MutuallyExclusive` for type = note: this error originates in the macro `::juniper::sa::assert_type_ne_all` which comes from the expansion of the derive macro `GraphQLUnion` (in Nightly builds, run with -Z macro-backtrace for more info) error[E0277]: the trait bound `std::string::String: GraphQLObject<__S>` is not satisfied - --> fail/union/struct_same_type_ugly.rs:4:14 + --> fail/union/struct_same_type_ugly.rs:5:14 | -4 | #[graphql(on String = Character::a)] - | ^^^^^^ the trait `GraphQLObject<__S>` is not implemented for `std::string::String` +5 | #[graphql(on std::string::String = Character::b)] + | ^^^^^^^^^^^^^^^^^^^ the trait `GraphQLObject<__S>` is not implemented for `std::string::String` | = help: the following other types implement trait `GraphQLObject`: <&T as GraphQLObject> @@ -27,10 +27,10 @@ error[E0277]: the trait bound `std::string::String: GraphQLObject<__S>` is not s as GraphQLObject> error[E0277]: the trait bound `std::string::String: GraphQLObject<__S>` is not satisfied - --> fail/union/struct_same_type_ugly.rs:5:14 + --> fail/union/struct_same_type_ugly.rs:4:14 | -5 | #[graphql(on std::string::String = Character::b)] - | ^^^^^^^^^^^^^^^^^^^ the trait `GraphQLObject<__S>` is not implemented for `std::string::String` +4 | #[graphql(on String = Character::a)] + | ^^^^^^ the trait `GraphQLObject<__S>` is not implemented for `std::string::String` | = help: the following other types implement trait `GraphQLObject`: <&T as GraphQLObject> From caa9495f011c1bef2aa814c6d8995d6d54a5ae07 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue, 23 Jul 2024 14:43:02 +0200 Subject: [PATCH 3/6] Upgrade `actix-ws` crate from 0.2 to 0.3 version (#1267) - bump up MSRV to 1.75 in `juniper_actix` crate Additionally: - remove redundant `InterruptableStream` definitions in `juniper_graphql_ws` crate Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kai Ren --- .github/workflows/ci.yml | 10 +++++----- juniper_actix/CHANGELOG.md | 15 ++++++++++++++- juniper_actix/Cargo.toml | 4 ++-- .../src/graphql_transport_ws/mod.rs | 17 ----------------- juniper_graphql_ws/src/graphql_ws/mod.rs | 17 ----------------- 5 files changed, 21 insertions(+), 42 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ac21383b9..c602cee28 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -150,7 +150,7 @@ jobs: - juniper - juniper_subscriptions - juniper_graphql_ws - - juniper_actix + #- juniper_actix - juniper_axum - juniper_hyper - juniper_rocket @@ -159,6 +159,10 @@ jobs: - ubuntu - macOS - windows + include: + - { msrv: "1.75.0", crate: "juniper_actix", os: "ubuntu" } + - { msrv: "1.75.0", crate: "juniper_actix", os: "macOS" } + - { msrv: "1.75.0", crate: "juniper_actix", os: "windows" } runs-on: ${{ matrix.os }}-latest steps: - uses: actions/checkout@v4 @@ -172,10 +176,6 @@ jobs: - run: cargo +nightly update -Z minimal-versions - run: make test.cargo crate=${{ matrix.crate }} - if: ${{ matrix.crate != 'juniper_actix' }} - # TODO: Remove once MSRV bumps up >=1.75. - - run: cargo check -p ${{ matrix.crate }} --all-features - if: ${{ matrix.crate == 'juniper_actix' }} package: name: check (package) diff --git a/juniper_actix/CHANGELOG.md b/juniper_actix/CHANGELOG.md index a8f65c847..f19890acd 100644 --- a/juniper_actix/CHANGELOG.md +++ b/juniper_actix/CHANGELOG.md @@ -6,6 +6,18 @@ All user visible changes to `juniper_actix` crate will be documented in this fil +## master + +### BC Breaks + +- Switched to 0.3 version of [`actix-ws` crate]. ([#1267]) +- Bumped up [MSRV] to 1.75 due to [`actix-ws` crate] requirements. ([#1267]) + +[#1267]: /../../pull/1267 + + + + ## [0.5.0] · 2024-03-20 [0.5.0]: /../../tree/juniper_actix-v0.5.0/juniper_actix @@ -49,4 +61,5 @@ See [old CHANGELOG](/../../blob/juniper_actix-v0.4.0/juniper_actix/CHANGELOG.md) [`juniper_graphql_ws` crate]: https://docs.rs/juniper_graphql_ws [Semantic Versioning 2.0.0]: https://semver.org [graphql-transport-ws]: https://github.com/enisdenjo/graphql-ws/blob/v5.14.0/PROTOCOL.md -[graphql-ws]: https://github.com/apollographql/subscriptions-transport-ws/blob/v0.11.0/PROTOCOL.md \ No newline at end of file +[graphql-ws]: https://github.com/apollographql/subscriptions-transport-ws/blob/v0.11.0/PROTOCOL.md +[MSRV]: https://doc.rust-lang.org/cargo/reference/manifest.html#the-rust-version-field diff --git a/juniper_actix/Cargo.toml b/juniper_actix/Cargo.toml index e45c7d9ef..73888ef27 100644 --- a/juniper_actix/Cargo.toml +++ b/juniper_actix/Cargo.toml @@ -2,7 +2,7 @@ name = "juniper_actix" version = "0.5.0" edition = "2021" -rust-version = "1.73" +rust-version = "1.75" description = "`juniper` GraphQL integration with `actix-web`." license = "BSD-2-Clause" authors = [ @@ -27,7 +27,7 @@ subscriptions = ["dep:actix-ws", "dep:juniper_graphql_ws"] [dependencies] actix-http = "3.2" actix-web = "4.4" -actix-ws = { version = "0.2", optional = true } +actix-ws = { version = "0.3", optional = true } anyhow = "1.0.47" futures = "0.3.22" juniper = { version = "0.16", path = "../juniper", default-features = false } diff --git a/juniper_graphql_ws/src/graphql_transport_ws/mod.rs b/juniper_graphql_ws/src/graphql_transport_ws/mod.rs index 8553c189a..365f6037b 100644 --- a/juniper_graphql_ws/src/graphql_transport_ws/mod.rs +++ b/juniper_graphql_ws/src/graphql_transport_ws/mod.rs @@ -290,23 +290,6 @@ impl> ConnectionState { } } -struct InterruptableStream { - stream: S, - rx: oneshot::Receiver<()>, -} - -impl Stream for InterruptableStream { - type Item = S::Item; - - fn poll_next(mut self: Pin<&mut Self>, cx: &mut Context) -> Poll> { - match Pin::new(&mut self.rx).poll(cx) { - Poll::Ready(_) => return Poll::Ready(None), - Poll::Pending => {} - } - Pin::new(&mut self.stream).poll_next(cx) - } -} - /// SubscriptionStartState is the state for a subscription operation. enum SubscriptionStartState { /// Init is the start before being polled for the first time. diff --git a/juniper_graphql_ws/src/graphql_ws/mod.rs b/juniper_graphql_ws/src/graphql_ws/mod.rs index 87950717b..fcc30afec 100644 --- a/juniper_graphql_ws/src/graphql_ws/mod.rs +++ b/juniper_graphql_ws/src/graphql_ws/mod.rs @@ -260,23 +260,6 @@ impl> ConnectionState { } } -struct InterruptableStream { - stream: S, - rx: oneshot::Receiver<()>, -} - -impl Stream for InterruptableStream { - type Item = S::Item; - - fn poll_next(mut self: Pin<&mut Self>, cx: &mut Context) -> Poll> { - match Pin::new(&mut self.rx).poll(cx) { - Poll::Ready(_) => return Poll::Ready(None), - Poll::Pending => {} - } - Pin::new(&mut self.stream).poll_next(cx) - } -} - /// SubscriptionStartState is the state for a subscription operation. enum SubscriptionStartState { /// Init is the start before being polled for the first time. From 5447cc63de48d1e1985f8c79772aa4194b1a399e Mon Sep 17 00:00:00 2001 From: tyranron Date: Tue, 23 Jul 2024 16:08:29 +0300 Subject: [PATCH 4/6] Prepare 0.6.0 release of `juniper_actix` crate --- juniper_actix/CHANGELOG.md | 3 ++- juniper_actix/Cargo.toml | 2 +- juniper_actix/README.md | 6 +++--- 3 files changed, 6 insertions(+), 5 deletions(-) diff --git a/juniper_actix/CHANGELOG.md b/juniper_actix/CHANGELOG.md index f19890acd..e478340f4 100644 --- a/juniper_actix/CHANGELOG.md +++ b/juniper_actix/CHANGELOG.md @@ -6,7 +6,8 @@ All user visible changes to `juniper_actix` crate will be documented in this fil -## master +## [0.6.0] · 2024-07-23 +[0.6.0]: /../../tree/juniper_actix-v0.6.0/juniper_actix ### BC Breaks diff --git a/juniper_actix/Cargo.toml b/juniper_actix/Cargo.toml index 73888ef27..c68b2a2de 100644 --- a/juniper_actix/Cargo.toml +++ b/juniper_actix/Cargo.toml @@ -1,6 +1,6 @@ [package] name = "juniper_actix" -version = "0.5.0" +version = "0.6.0" edition = "2021" rust-version = "1.75" description = "`juniper` GraphQL integration with `actix-web`." diff --git a/juniper_actix/README.md b/juniper_actix/README.md index 1932d5d7b..f778ef1d5 100644 --- a/juniper_actix/README.md +++ b/juniper_actix/README.md @@ -6,7 +6,7 @@ [![CI](https://github.com/graphql-rust/juniper/workflows/CI/badge.svg?branch=master "CI")](https://github.com/graphql-rust/juniper/actions?query=workflow%3ACI+branch%3Amaster) [![Rust 1.73+](https://img.shields.io/badge/rustc-1.73+-lightgray.svg "Rust 1.73+")](https://blog.rust-lang.org/2023/10/05/Rust-1.73.0.html) -- [Changelog](https://github.com/graphql-rust/juniper/blob/juniper_actix-v0.5.0/juniper_actix/CHANGELOG.md) +- [Changelog](https://github.com/graphql-rust/juniper/blob/juniper_actix-v0.6.0/juniper_actix/CHANGELOG.md) [`actix-web`] web server integration for [`juniper`] ([GraphQL] implementation for [Rust]). @@ -33,7 +33,7 @@ Check [`examples/subscription.rs`][1] for example code of a working [`actix-web` ## License -This project is licensed under [BSD 2-Clause License](https://github.com/graphql-rust/juniper/blob/juniper_actix-v0.5.0/juniper_actix/LICENSE). +This project is licensed under [BSD 2-Clause License](https://github.com/graphql-rust/juniper/blob/juniper_actix-v0.6.0/juniper_actix/LICENSE). @@ -46,5 +46,5 @@ This project is licensed under [BSD 2-Clause License](https://github.com/graphql [Juniper Book]: https://graphql-rust.github.io/juniper [Rust]: https://www.rust-lang.org -[1]: https://github.com/graphql-rust/juniper/blob/juniper_actix-v0.5.0/juniper_actix/examples/subscription.rs +[1]: https://github.com/graphql-rust/juniper/blob/juniper_actix-v0.6.0/juniper_actix/examples/subscription.rs From 7db44c0b2893ec9aac41a35fb0516466fec08b15 Mon Sep 17 00:00:00 2001 From: tyranron Date: Fri, 26 Jul 2024 19:13:47 +0300 Subject: [PATCH 5/6] Tune lints for 1.80 Rust --- juniper/Cargo.toml | 3 +++ juniper_actix/src/lib.rs | 4 ++-- juniper_axum/src/lib.rs | 1 - juniper_warp/src/subscriptions.rs | 4 ++-- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/juniper/Cargo.toml b/juniper/Cargo.toml index 9ff926d43..82ef9d532 100644 --- a/juniper/Cargo.toml +++ b/juniper/Cargo.toml @@ -85,3 +85,6 @@ tokio = { version = "1.0", features = ["macros", "time", "rt-multi-thread"] } name = "bench" harness = false path = "benches/bench.rs" + +[lints.rust] +unexpected_cfgs = { level = "warn", check-cfg = ['cfg(nightly)'] } \ No newline at end of file diff --git a/juniper_actix/src/lib.rs b/juniper_actix/src/lib.rs index 4e8e63315..781062007 100644 --- a/juniper_actix/src/lib.rs +++ b/juniper_actix/src/lib.rs @@ -230,8 +230,8 @@ pub mod subscriptions { /// an authentication based on the parameters provided by a client. /// /// > __WARNING__: This protocol has been deprecated in favor of the - /// [new `graphql-transport-ws` GraphQL over WebSocket Protocol][new], which is - /// provided by the [`graphql_transport_ws_handler()`] function. + /// > [new `graphql-transport-ws` GraphQL over WebSocket Protocol][new], which is + /// > provided by the [`graphql_transport_ws_handler()`] function. /// /// [new]: https://github.com/enisdenjo/graphql-ws/blob/v5.14.0/PROTOCOL.md /// [old]: https://github.com/apollographql/subscriptions-transport-ws/blob/v0.11.0/PROTOCOL.md diff --git a/juniper_axum/src/lib.rs b/juniper_axum/src/lib.rs index 205669a67..20c2099f5 100644 --- a/juniper_axum/src/lib.rs +++ b/juniper_axum/src/lib.rs @@ -67,7 +67,6 @@ pub use self::subscriptions::{graphql_transport_ws, graphql_ws, ws}; /// /// [`extract`]: axum::extract /// [`Handler`]: axum::handler::Handler -#[cfg_attr(text, axum::debug_handler)] pub async fn graphql( Extension(schema): Extension, JuniperRequest(req): JuniperRequest, diff --git a/juniper_warp/src/subscriptions.rs b/juniper_warp/src/subscriptions.rs index 6511c235f..d54597e4f 100644 --- a/juniper_warp/src/subscriptions.rs +++ b/juniper_warp/src/subscriptions.rs @@ -232,8 +232,8 @@ where /// an authentication based on the parameters provided by a client. /// /// > __WARNING__: This protocol has been deprecated in favor of the -/// [new `graphql-transport-ws` GraphQL over WebSocket Protocol][new], which is -/// provided by the [`serve_graphql_transport_ws()`] function. +/// > [new `graphql-transport-ws` GraphQL over WebSocket Protocol][new], which is +/// > provided by the [`serve_graphql_transport_ws()`] function. /// /// [new]: https://github.com/enisdenjo/graphql-ws/blob/v5.14.0/PROTOCOL.md /// [old]: https://github.com/apollographql/subscriptions-transport-ws/blob/v0.11.0/PROTOCOL.md From b1f4ecb1e042df7136b5a2555df3a472543ee48e Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Fri, 2 Aug 2024 09:55:50 +0000 Subject: [PATCH 6/6] Update GraphiQL from 3.3.2 to 3.4.0 version (#1269) Signed-off-by: dependabot[bot] Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kai Ren --- juniper/CHANGELOG.md | 4 ++-- juniper/Cargo.toml | 2 +- juniper/package.json | 2 +- juniper/src/http/graphiql.html | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/juniper/CHANGELOG.md b/juniper/CHANGELOG.md index 21e0c3bd5..1c563baa8 100644 --- a/juniper/CHANGELOG.md +++ b/juniper/CHANGELOG.md @@ -17,10 +17,10 @@ All user visible changes to `juniper` crate will be documented in this file. Thi ### Changed -- Updated [GraphiQL] to [3.3.2 version](https://github.com/graphql/graphiql/blob/graphiql%403.3.2/packages/graphiql/CHANGELOG.md#332). ([#1265]) +- Updated [GraphiQL] to [3.4.0 version](https://github.com/graphql/graphiql/blob/graphiql%403.4.0/packages/graphiql/CHANGELOG.md#340). ([#1269]) [#1252]: /../../pull/1252 -[#1265]: /../../pull/1265 +[#1269]: /../../pull/1269 diff --git a/juniper/Cargo.toml b/juniper/Cargo.toml index 82ef9d532..f12400b53 100644 --- a/juniper/Cargo.toml +++ b/juniper/Cargo.toml @@ -87,4 +87,4 @@ harness = false path = "benches/bench.rs" [lints.rust] -unexpected_cfgs = { level = "warn", check-cfg = ['cfg(nightly)'] } \ No newline at end of file +unexpected_cfgs = { level = "warn", check-cfg = ['cfg(nightly)'] } diff --git a/juniper/package.json b/juniper/package.json index 6196fb403..eb4a46f19 100644 --- a/juniper/package.json +++ b/juniper/package.json @@ -4,7 +4,7 @@ "postinstall": "make graphiql graphql-playground" }, "dependencies": { - "graphiql": "3.3.2", + "graphiql": "3.4.0", "graphql-playground-react": "1.7.28" } } diff --git a/juniper/src/http/graphiql.html b/juniper/src/http/graphiql.html index 20bce4d2b..7cf55dec1 100644 --- a/juniper/src/http/graphiql.html +++ b/juniper/src/http/graphiql.html @@ -42,10 +42,10 @@ favored resource bundler. --> - +