fix: apply consistent mapping order isAuthorized (OZ_N-05)

graphprotocol · Oct 4, 2024 · 8a5b876 · 8a5b876
1 parent 4754297
commit 8a5b876
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/horizon/contracts/data-service/utilities/ProvisionManager.sol b/packages/horizon/contracts/data-service/utilities/ProvisionManager.sol
@@ -84,7 +84,7 @@ abstract contract ProvisionManager is Initializable, GraphDirectory, ProvisionMa
      */
     modifier onlyProvisionAuthorized(address serviceProvider) {
         require(
-            _graphStaking().isAuthorized(msg.sender, serviceProvider, address(this)),
+            _graphStaking().isAuthorized(serviceProvider, msg.sender, address(this)),
             ProvisionManagerNotAuthorized(serviceProvider, msg.sender)
         );
         _;

diff --git a/packages/horizon/test/shared/horizon-staking/HorizonStakingShared.t.sol b/packages/horizon/test/shared/horizon-staking/HorizonStakingShared.t.sol
@@ -755,7 +755,7 @@ abstract contract HorizonStakingSharedTest is GraphBaseTest {
 
         // before
         bool beforeOperatorAllowed = _getStorage_OperatorAuth(msgSender, operator, verifier, legacy);
-        bool beforeOperatorAllowedGetter = staking.isAuthorized(operator, msgSender, verifier);
+        bool beforeOperatorAllowedGetter = staking.isAuthorized(msgSender, operator, verifier);
         assertEq(beforeOperatorAllowed, beforeOperatorAllowedGetter);
 
         // setOperator
@@ -769,7 +769,7 @@ abstract contract HorizonStakingSharedTest is GraphBaseTest {
 
         // after
         bool afterOperatorAllowed = _getStorage_OperatorAuth(msgSender, operator, verifier, legacy);
-        bool afterOperatorAllowedGetter = staking.isAuthorized(operator, msgSender, verifier);
+        bool afterOperatorAllowedGetter = staking.isAuthorized(msgSender, operator, verifier);
         assertEq(afterOperatorAllowed, afterOperatorAllowedGetter);
 
         // assert
@@ -1487,8 +1487,8 @@ abstract contract HorizonStakingSharedTest is GraphBaseTest {
         );
 
         bool isAuth = staking.isAuthorized(
-            msgSender,
             beforeValues.allocation.indexer,
+            msgSender,
             subgraphDataServiceLegacyAddress
         );
         address rewardsDestination = _getStorage_RewardsDestination(beforeValues.allocation.indexer);