Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors and Non-Nullability #67

Open
peldax opened this issue Nov 4, 2020 · 1 comment
Open

Errors and Non-Nullability #67

peldax opened this issue Nov 4, 2020 · 1 comment
Labels
Ctg - Spec incompatibility Something is not compliant with specification Status - Wontfix This will not be worked on

Comments

@peldax
Copy link
Member

peldax commented Nov 4, 2020

http://spec.graphql.org/draft/#sec-Errors-and-Non-Nullability
@peldax peldax added this to the v1.0 milestone Nov 4, 2020
@peldax peldax added Ctg - Spec incompatibility Something is not compliant with specification Type - Bug Something isn't working Type - Enhancement New feature or request and removed Type - Bug Something isn't working labels Nov 4, 2020
@peldax
Copy link
Member Author

peldax commented Nov 10, 2020 •
edited
Loading

Currently, this error shuts whole query down and response contain only the error without partial data.

I am not sure how to handle this for various reasons.

  • In my point of view, this type of error (marking a field as not nullable and returning null) is purely a programmers error
  • We would need to also catch PHPs TypeError, because most likely the resolve function would be typed as if it cannot return null.

@peldax peldax added the Status - On hold Some information is missing/not sure how to handle. label Nov 16, 2020
@peldax peldax removed this from the v1.0 milestone Nov 18, 2020
@peldax peldax removed the Type - Enhancement New feature or request label May 22, 2021
@peldax peldax added Status - Wontfix This will not be worked on and removed Status - On hold Some information is missing/not sure how to handle. labels Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Ctg - Spec incompatibility Something is not compliant with specification Status - Wontfix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@peldax